From: Stephen Hemminger <stephen@networkplumber.org>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Pavel Belous <Pavel.Belous@aquantia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 04/10] net/atlantic: fix buffer overflow
Date: Sat, 9 Mar 2019 07:24:40 -0800 [thread overview]
Message-ID: <20190309072440.4befa21e@shemminger-XPS-13-9360> (raw)
In-Reply-To: <b4630c7b4e565498c2f16f55030d0de4a43af28a.1552138867.git.igor.russkikh@aquantia.com>
On Sat, 9 Mar 2019 14:03:30 +0000
Igor Russkikh <Igor.Russkikh@aquantia.com> wrote:
> From: Pavel Belous <Pavel.Belous@aquantia.com>
>
> Found by Coverity scan. This is a real memory corruption.
> There is no need in extra RTE_ALIGN macros since the
> request/result structures are 4-byte aligned by definition.
When fixing bugs found by Coverity it is best to mark these with
the Coverity number. The convention (in Linux kernel) is shown
by these examples:
Addresses-Coverity-ID: 1476095 ("Bad bit shift operation")
Detected by CoverityScan, CID#1476031 ("Dereference before null check")
Should this go in the style guide somewhere?
next prev parent reply other threads:[~2019-03-09 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1552138867.git.igor.russkikh@aquantia.com>
2019-03-09 14:03 ` [dpdk-stable] [PATCH v2 01/10] net/atlantic: fix negative error codes Igor Russkikh
2019-03-09 14:03 ` [dpdk-stable] [PATCH v2 04/10] net/atlantic: fix buffer overflow Igor Russkikh
2019-03-09 15:24 ` Stephen Hemminger [this message]
2019-03-09 14:03 ` [dpdk-stable] [PATCH v2 06/10] net/atlantic: fix EEPROM get for small and uneven lengths Igor Russkikh
2019-03-09 14:03 ` [dpdk-stable] [PATCH v2 07/10] net/atlantic: fix link configuration Igor Russkikh
2019-03-09 14:03 ` [dpdk-stable] [PATCH v2 09/10] net/atlantic: fix missing VLAN filter offload Igor Russkikh
2019-03-09 14:03 ` [dpdk-stable] [PATCH v2 10/10] net/atlantic: fix xstats to return correct number of items Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309072440.4befa21e@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=Igor.Russkikh@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).