From: Jens Freimann <jfreimann@redhat.com>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>,
David Marchand <david.marchand@redhat.com>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] vhost: fix passing destroyed device to destroy callback
Date: Tue, 9 Apr 2019 16:25:53 +0200 [thread overview]
Message-ID: <20190409142553.w3hisc5qklgr5pkj@jenstp.localdomain> (raw)
In-Reply-To: <20190409133622.14729-1-i.maximets@samsung.com>
On Tue, Apr 09, 2019 at 04:36:22PM +0300, Ilya Maximets wrote:
>Application should be able to obtain information like 'ifname' from
>the 'vid' passed to 'destroy_connection' callback. Currently, all the
>API calls with passed 'vid' fails with 'device not found'.
>
>Fixes: efba12a78ddf ("vhost: add user callbacks for socket open/close")
>Cc: stable@dpdk.org
>
>Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
>---
> lib/librte_vhost/socket.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Because the device is destroyed before the callback is done, vid is
not a valid index to look up device information any more. So, yes we
should destroy the device after the callback.
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
regards,
Jens
next prev parent reply other threads:[~2019-04-09 14:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190409133629eucas1p2ecfe7c4771bb6add694596cf75cf3e70@eucas1p2.samsung.com>
2019-04-09 13:36 ` Ilya Maximets
2019-04-09 14:25 ` Jens Freimann [this message]
2019-04-10 7:24 ` David Marchand
2019-04-10 7:53 ` Ilya Maximets
2019-04-10 8:07 ` David Marchand
2019-04-11 8:53 ` Ilya Maximets
2019-04-12 4:39 ` Tiwei Bie
2019-04-12 8:11 ` Ilya Maximets
[not found] ` <CGME20190412083233eucas1p181a34d6544869582defba814e4caeb52@eucas1p1.samsung.com>
2019-04-12 8:32 ` [dpdk-stable] [PATCH v2] " Ilya Maximets
2019-04-15 6:21 ` Tiwei Bie
2019-04-17 7:54 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409142553.w3hisc5qklgr5pkj@jenstp.localdomain \
--to=jfreimann@redhat.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).