From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id ABED5A0096 for ; Wed, 10 Apr 2019 18:45:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 94F891B105; Wed, 10 Apr 2019 18:45:48 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 731D11B105 for ; Wed, 10 Apr 2019 18:45:47 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D76FD308CF86; Wed, 10 Apr 2019 16:45:46 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-94.ams2.redhat.com [10.36.117.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 66E3F5D964; Wed, 10 Apr 2019 16:45:44 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Anatoly Burakov , Olivier Matz , dpdk stable Date: Wed, 10 Apr 2019 17:43:57 +0100 Message-Id: <20190410164411.10546-49-ktraynor@redhat.com> In-Reply-To: <20190410164411.10546-1-ktraynor@redhat.com> References: <20190410164411.10546-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 10 Apr 2019 16:45:46 +0000 (UTC) Subject: [dpdk-stable] patch 'eal: fix control threads pinnning' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/16/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >From 380430e471720ddd2c6c23418b8b11226740b155 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Tue, 19 Feb 2019 21:41:10 +0100 Subject: [PATCH] eal: fix control threads pinnning [ upstream commit 759b9be661222768356ee50d8d15dc4d33646432 ] pthread_setaffinity_np returns a >0 value on error. We could end up letting the ctrl threads on the current process cpu affinity. Fixes: d651ee4919cd ("eal: set affinity for control threads") Signed-off-by: David Marchand Reviewed-by: Anatoly Burakov Reviewed-by: Olivier Matz --- lib/librte_eal/common/eal_common_thread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c index 48ef4d6de..a3985ce86 100644 --- a/lib/librte_eal/common/eal_common_thread.c +++ b/lib/librte_eal/common/eal_common_thread.c @@ -210,5 +210,5 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name, ret = pthread_setaffinity_np(*thread, sizeof(cpuset), &cpuset); - if (ret < 0) + if (ret) goto fail; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-10 14:06:11.654487276 +0100 +++ 0049-eal-fix-control-threads-pinnning.patch 2019-04-10 14:06:07.990291359 +0100 @@ -1,14 +1,15 @@ -From 759b9be661222768356ee50d8d15dc4d33646432 Mon Sep 17 00:00:00 2001 +From 380430e471720ddd2c6c23418b8b11226740b155 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Tue, 19 Feb 2019 21:41:10 +0100 Subject: [PATCH] eal: fix control threads pinnning +[ upstream commit 759b9be661222768356ee50d8d15dc4d33646432 ] + pthread_setaffinity_np returns a >0 value on error. We could end up letting the ctrl threads on the current process cpu affinity. Fixes: d651ee4919cd ("eal: set affinity for control threads") -Cc: stable@dpdk.org Signed-off-by: David Marchand Reviewed-by: Anatoly Burakov