From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F0107A0096 for ; Wed, 10 Apr 2019 18:45:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E55D61B105; Wed, 10 Apr 2019 18:45:54 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 777A11B105 for ; Wed, 10 Apr 2019 18:45:52 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E44518125B for ; Wed, 10 Apr 2019 16:45:51 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-94.ams2.redhat.com [10.36.117.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 245435D961; Wed, 10 Apr 2019 16:45:50 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: dpdk stable Date: Wed, 10 Apr 2019 17:43:59 +0100 Message-Id: <20190410164411.10546-51-ktraynor@redhat.com> In-Reply-To: <20190410164411.10546-1-ktraynor@redhat.com> References: <20190410164411.10546-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 10 Apr 2019 16:45:51 +0000 (UTC) Subject: [dpdk-stable] patch 'eal: remove dead code in core list parsing' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/16/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >From 95f7e35132236e3ed15ce542fcc92d4d9211048d Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 13 Feb 2019 21:06:58 +0100 Subject: [PATCH] eal: remove dead code in core list parsing [ upstream commit 33df941d79ad7966b82d882ad277e625f6c3a017 ] We don't need to look for trailing spaces. This is a copy/paste block from eal_parse_coremask(). Remove it and the associated comment. Fixes: d888cb8b9613 ("eal: add core list input format") Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_options.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 7ba1c449b..74ca26340 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -567,8 +567,8 @@ eal_parse_corelist(const char *corelist) { struct rte_config *cfg = rte_eal_get_configuration(); - int i, idx = 0; unsigned count = 0; char *end = NULL; int min, max; + int idx; if (eal_service_cores_parsed()) @@ -580,10 +580,7 @@ eal_parse_corelist(const char *corelist) return -1; - /* Remove all blank characters ahead and after */ + /* Remove all blank characters ahead */ while (isblank(*corelist)) corelist++; - i = strlen(corelist); - while ((i > 0) && isblank(corelist[i - 1])) - i--; /* Reset config */ -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-10 14:06:11.810869665 +0100 +++ 0051-eal-remove-dead-code-in-core-list-parsing.patch 2019-04-10 14:06:08.000291130 +0100 @@ -1,14 +1,15 @@ -From 33df941d79ad7966b82d882ad277e625f6c3a017 Mon Sep 17 00:00:00 2001 +From 95f7e35132236e3ed15ce542fcc92d4d9211048d Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 13 Feb 2019 21:06:58 +0100 Subject: [PATCH] eal: remove dead code in core list parsing +[ upstream commit 33df941d79ad7966b82d882ad277e625f6c3a017 ] + We don't need to look for trailing spaces. This is a copy/paste block from eal_parse_coremask(). Remove it and the associated comment. Fixes: d888cb8b9613 ("eal: add core list input format") -Cc: stable@dpdk.org Signed-off-by: David Marchand --- @@ -16,10 +17,10 @@ 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c -index 9e61ee436..8a431457b 100644 +index 7ba1c449b..74ca26340 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c -@@ -568,8 +568,8 @@ eal_parse_corelist(const char *corelist) +@@ -567,8 +567,8 @@ eal_parse_corelist(const char *corelist) { struct rte_config *cfg = rte_eal_get_configuration(); - int i, idx = 0; @@ -29,7 +30,7 @@ + int idx; if (eal_service_cores_parsed()) -@@ -581,10 +581,7 @@ eal_parse_corelist(const char *corelist) +@@ -580,10 +580,7 @@ eal_parse_corelist(const char *corelist) return -1; - /* Remove all blank characters ahead and after */