* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] eal: support strlcat function [not found] ` <20190117173032.42076-1-bruce.richardson@intel.com> @ 2019-04-16 14:29 ` Kevin Traynor 2019-04-16 14:37 ` Bruce Richardson 0 siblings, 1 reply; 3+ messages in thread From: Kevin Traynor @ 2019-04-16 14:29 UTC (permalink / raw) To: Bruce Richardson, dev; +Cc: Ferruh Yigit, Reshma Pattan, stable On 17/01/2019 17:30, Bruce Richardson wrote: > Add the strlcat function to DPDK to exist alongside the strlcpy one. > While strncat is generally safe for use for concatenation, the API for the > strlcat function is perhaps a little nicer to use, and supports truncation > detection. > > See commit 5364de644a4b ("eal: support strlcpy function") for more > details on the function selection logic, since we only should be using the > DPDK-provided version when no system-provided version is present. > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Hi - I'd like to backport this to 18.11 stable branch. Not having it is starting to cause build failures with backports. Let me know if any objection. thanks, Kevin. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] eal: support strlcat function 2019-04-16 14:29 ` [dpdk-stable] [dpdk-dev] [PATCH v3] eal: support strlcat function Kevin Traynor @ 2019-04-16 14:37 ` Bruce Richardson 2019-04-16 16:03 ` Ferruh Yigit 0 siblings, 1 reply; 3+ messages in thread From: Bruce Richardson @ 2019-04-16 14:37 UTC (permalink / raw) To: Kevin Traynor; +Cc: dev, Ferruh Yigit, Reshma Pattan, stable On Tue, Apr 16, 2019 at 03:29:52PM +0100, Kevin Traynor wrote: > On 17/01/2019 17:30, Bruce Richardson wrote: > > Add the strlcat function to DPDK to exist alongside the strlcpy one. > > While strncat is generally safe for use for concatenation, the API for the > > strlcat function is perhaps a little nicer to use, and supports truncation > > detection. > > > > See commit 5364de644a4b ("eal: support strlcpy function") for more > > details on the function selection logic, since we only should be using the > > DPDK-provided version when no system-provided version is present. > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Hi - I'd like to backport this to 18.11 stable branch. Not having it is > starting to cause build failures with backports. Let me know if any > objection. > Go for it! No objections here, I think it makes sense. /Bruce ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] eal: support strlcat function 2019-04-16 14:37 ` Bruce Richardson @ 2019-04-16 16:03 ` Ferruh Yigit 0 siblings, 0 replies; 3+ messages in thread From: Ferruh Yigit @ 2019-04-16 16:03 UTC (permalink / raw) To: Bruce Richardson, Kevin Traynor; +Cc: dev, Reshma Pattan, stable On 4/16/2019 3:37 PM, Bruce Richardson wrote: > On Tue, Apr 16, 2019 at 03:29:52PM +0100, Kevin Traynor wrote: >> On 17/01/2019 17:30, Bruce Richardson wrote: >>> Add the strlcat function to DPDK to exist alongside the strlcpy one. >>> While strncat is generally safe for use for concatenation, the API for the >>> strlcat function is perhaps a little nicer to use, and supports truncation >>> detection. >>> >>> See commit 5364de644a4b ("eal: support strlcpy function") for more >>> details on the function selection logic, since we only should be using the >>> DPDK-provided version when no system-provided version is present. >>> >>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> >>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> >> >> Hi - I'd like to backport this to 18.11 stable branch. Not having it is >> starting to cause build failures with backports. Let me know if any >> objection. >> > Go for it! No objections here, I think it makes sense. +1 for the backport. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-16 16:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190116124836.40132-1-bruce.richardson@intel.com>
[not found] ` <20190117173032.42076-1-bruce.richardson@intel.com>
2019-04-16 14:29 ` [dpdk-stable] [dpdk-dev] [PATCH v3] eal: support strlcat function Kevin Traynor
2019-04-16 14:37 ` Bruce Richardson
2019-04-16 16:03 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).