From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1CD02A00E6 for ; Tue, 16 Apr 2019 16:38:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D6C91B4D0; Tue, 16 Apr 2019 16:38:06 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8B2CC1B4F1 for ; Tue, 16 Apr 2019 16:38:04 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0198330BC65E; Tue, 16 Apr 2019 14:38:04 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-214.ams2.redhat.com [10.36.117.214]) by smtp.corp.redhat.com (Postfix) with ESMTP id 253731001E92; Tue, 16 Apr 2019 14:38:02 +0000 (UTC) From: Kevin Traynor To: Igor Russkikh Cc: dpdk stable Date: Tue, 16 Apr 2019 15:36:39 +0100 Message-Id: <20190416143719.21601-21-ktraynor@redhat.com> In-Reply-To: <20190416143719.21601-1-ktraynor@redhat.com> References: <20190416143719.21601-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 16 Apr 2019 14:38:04 +0000 (UTC) Subject: [dpdk-stable] patch 'net/atlantic: remove extra checks for error codes' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/24/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >From ea3d0a12a99272619620cc29d1a3143ae48b818c Mon Sep 17 00:00:00 2001 From: Igor Russkikh Date: Tue, 12 Mar 2019 15:24:55 +0000 Subject: [PATCH] net/atlantic: remove extra checks for error codes [ upstream commit 0b504bcfefc29fbafd9278603022093df401a85f ] Found by Coverity scan. Checks are useless because at these code places err is always zero. Fixes: 86d36773bd42 ("net/atlantic: implement firmware operations") Signed-off-by: Igor Russkikh --- drivers/net/atlantic/hw_atl/hw_atl_utils.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/atlantic/hw_atl/hw_atl_utils.c index f11093a50..13f02b9f9 100644 --- a/drivers/net/atlantic/hw_atl/hw_atl_utils.c +++ b/drivers/net/atlantic/hw_atl/hw_atl_utils.c @@ -463,6 +463,4 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self, } } while (sw.tid != fw.tid || 0xFFFFU == fw.len); - if (err < 0) - goto err_exit; if (rpc) { @@ -876,6 +874,5 @@ static int aq_fw1x_set_wol(struct aq_hw_s *self, bool wol_enabled, u8 *mac) err = hw_atl_utils_fw_rpc_call(self, rpc_size); - if (err < 0) - goto err_exit; + err_exit: return err; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-16 15:34:26.154890011 +0100 +++ 0021-net-atlantic-remove-extra-checks-for-error-codes.patch 2019-04-16 15:34:25.165180283 +0100 @@ -1,13 +1,14 @@ -From 0b504bcfefc29fbafd9278603022093df401a85f Mon Sep 17 00:00:00 2001 +From ea3d0a12a99272619620cc29d1a3143ae48b818c Mon Sep 17 00:00:00 2001 From: Igor Russkikh Date: Tue, 12 Mar 2019 15:24:55 +0000 Subject: [PATCH] net/atlantic: remove extra checks for error codes +[ upstream commit 0b504bcfefc29fbafd9278603022093df401a85f ] + Found by Coverity scan. Checks are useless because at these code places err is always zero. Fixes: 86d36773bd42 ("net/atlantic: implement firmware operations") -Cc: stable@dpdk.org Signed-off-by: Igor Russkikh ---