From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 943ECA06B4 for ; Tue, 16 Apr 2019 16:39:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5BF111B4EB; Tue, 16 Apr 2019 16:39:00 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B84151B4E3 for ; Tue, 16 Apr 2019 16:38:58 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2C246309E9B2; Tue, 16 Apr 2019 14:38:58 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-214.ams2.redhat.com [10.36.117.214]) by smtp.corp.redhat.com (Postfix) with ESMTP id 176B21001E92; Tue, 16 Apr 2019 14:38:56 +0000 (UTC) From: Kevin Traynor To: Chaitanya Babu Talluri Cc: Akhil Goyal , dpdk stable Date: Tue, 16 Apr 2019 15:37:07 +0100 Message-Id: <20190416143719.21601-49-ktraynor@redhat.com> In-Reply-To: <20190416143719.21601-1-ktraynor@redhat.com> References: <20190416143719.21601-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 16 Apr 2019 14:38:58 +0000 (UTC) Subject: [dpdk-stable] patch 'test/crypto: fix possible overflow using strlcat' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/24/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >From f5c74ea2816cbacf857a167c1370ba693981c9c3 Mon Sep 17 00:00:00 2001 From: Chaitanya Babu Talluri Date: Mon, 18 Mar 2019 12:36:36 +0000 Subject: [PATCH] test/crypto: fix possible overflow using strlcat [ upstream commit e3b91a3ef236b3bb6ee4db12cc285e8f87b942e7 ] strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") Signed-off-by: Chaitanya Babu Talluri Acked-by: Akhil Goyal --- test/test/test_cryptodev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c index 84065eb49..fbe8c21e6 100644 --- a/test/test/test_cryptodev.c +++ b/test/test/test_cryptodev.c @@ -16,4 +16,5 @@ #include #include +#include #ifdef RTE_LIBRTE_PMD_CRYPTO_SCHEDULER @@ -375,5 +376,5 @@ testsuite_setup(void) "%s%d", temp_str, i); strcpy(temp_str, vdev_args); - strcat(temp_str, ";"); + strlcat(temp_str, ";", sizeof(temp_str)); slave_core_count++; socket_id = lcore_config[i].socket_id; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-16 15:34:27.392951174 +0100 +++ 0049-test-crypto-fix-possible-overflow-using-strlcat.patch 2019-04-16 15:34:25.230178840 +0100 @@ -1,31 +1,32 @@ -From e3b91a3ef236b3bb6ee4db12cc285e8f87b942e7 Mon Sep 17 00:00:00 2001 +From f5c74ea2816cbacf857a167c1370ba693981c9c3 Mon Sep 17 00:00:00 2001 From: Chaitanya Babu Talluri Date: Mon, 18 Mar 2019 12:36:36 +0000 Subject: [PATCH] test/crypto: fix possible overflow using strlcat +[ upstream commit e3b91a3ef236b3bb6ee4db12cc285e8f87b942e7 ] + strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") -Cc: stable@dpdk.org Signed-off-by: Chaitanya Babu Talluri Acked-by: Akhil Goyal --- - app/test/test_cryptodev.c | 3 ++- + test/test/test_cryptodev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c -index 32f1893bc..2ff204137 100644 ---- a/app/test/test_cryptodev.c -+++ b/app/test/test_cryptodev.c +diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c +index 84065eb49..fbe8c21e6 100644 +--- a/test/test/test_cryptodev.c ++++ b/test/test/test_cryptodev.c @@ -16,4 +16,5 @@ #include #include +#include #ifdef RTE_LIBRTE_PMD_CRYPTO_SCHEDULER -@@ -376,5 +377,5 @@ testsuite_setup(void) +@@ -375,5 +376,5 @@ testsuite_setup(void) "%s%d", temp_str, i); strcpy(temp_str, vdev_args); - strcat(temp_str, ";");