From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 15C60A00E6 for ; Tue, 16 Apr 2019 16:39:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A9361B4D3; Tue, 16 Apr 2019 16:39:14 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3D98B1B4E9 for ; Tue, 16 Apr 2019 16:39:12 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 917253001572; Tue, 16 Apr 2019 14:39:11 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-214.ams2.redhat.com [10.36.117.214]) by smtp.corp.redhat.com (Postfix) with ESMTP id 23A291001E93; Tue, 16 Apr 2019 14:39:08 +0000 (UTC) From: Kevin Traynor To: Gavin Hu Cc: Ruifeng Wang , Joyce Kong , Phil Yang , Honnappa Nagarahalli , Ola Liljedahl , Jerin Jacob , Nipun Gupta , Konstantin Ananyev , dpdk stable Date: Tue, 16 Apr 2019 15:37:14 +0100 Message-Id: <20190416143719.21601-56-ktraynor@redhat.com> In-Reply-To: <20190416143719.21601-1-ktraynor@redhat.com> References: <20190416143719.21601-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 16 Apr 2019 14:39:11 +0000 (UTC) Subject: [dpdk-stable] patch 'test/spinlock: remove delay for correct benchmarking' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/24/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >From 6e8cc16a52e3b261ad099f5eb89f706dfb284c22 Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Fri, 8 Mar 2019 15:56:35 +0800 Subject: [PATCH] test/spinlock: remove delay for correct benchmarking [ upstream commit 9119ad305db027b5c87e27b13fde9d60f9aa9a1f ] The test is to benchmark the performance of spinlock by counting the number of spinlock acquire and release operations within the specified time. A typical pair of lock and unlock operations costs tens or hundreds of nano seconds, in comparison to this, delaying 1 us outside of the locked region is too much, compromising the goal of benchmarking the lock and unlock performance. Fixes: af75078fece3 ("first public release") Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Joyce Kong Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedahl Acked-by: Jerin Jacob Acked-by: Nipun Gupta Acked-by: Konstantin Ananyev --- test/test/test_spinlock.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/test/test_spinlock.c b/test/test/test_spinlock.c index 73bff128e..6795195ae 100644 --- a/test/test/test_spinlock.c +++ b/test/test/test_spinlock.c @@ -121,6 +121,4 @@ load_loop_fn(void *func_param) if (use_lock) rte_spinlock_unlock(&lk); - /* delay to make lock duty cycle slighlty realistic */ - rte_delay_us(1); time_diff = rte_get_timer_cycles() - begin; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-16 15:34:27.695249272 +0100 +++ 0056-test-spinlock-remove-delay-for-correct-benchmarking.patch 2019-04-16 15:34:25.235178729 +0100 @@ -1,8 +1,10 @@ -From 9119ad305db027b5c87e27b13fde9d60f9aa9a1f Mon Sep 17 00:00:00 2001 +From 6e8cc16a52e3b261ad099f5eb89f706dfb284c22 Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Fri, 8 Mar 2019 15:56:35 +0800 Subject: [PATCH] test/spinlock: remove delay for correct benchmarking +[ upstream commit 9119ad305db027b5c87e27b13fde9d60f9aa9a1f ] + The test is to benchmark the performance of spinlock by counting the number of spinlock acquire and release operations within the specified time. @@ -12,7 +14,6 @@ unlock performance. Fixes: af75078fece3 ("first public release") -Cc: stable@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang @@ -24,13 +25,13 @@ Acked-by: Nipun Gupta Acked-by: Konstantin Ananyev --- - app/test/test_spinlock.c | 2 -- + test/test/test_spinlock.c | 2 -- 1 file changed, 2 deletions(-) -diff --git a/app/test/test_spinlock.c b/app/test/test_spinlock.c +diff --git a/test/test/test_spinlock.c b/test/test/test_spinlock.c index 73bff128e..6795195ae 100644 ---- a/app/test/test_spinlock.c -+++ b/app/test/test_spinlock.c +--- a/test/test/test_spinlock.c ++++ b/test/test/test_spinlock.c @@ -121,6 +121,4 @@ load_loop_fn(void *func_param) if (use_lock) rte_spinlock_unlock(&lk);