From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0E75FA05D3 for ; Thu, 25 Apr 2019 17:42:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 01FA51B5C4; Thu, 25 Apr 2019 17:42:06 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id EEA821B5FC for ; Thu, 25 Apr 2019 17:42:03 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 423A27E9C0; Thu, 25 Apr 2019 15:42:03 +0000 (UTC) Received: from rh.redhat.com (unknown [10.36.116.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31ED45D9CD; Thu, 25 Apr 2019 15:42:02 +0000 (UTC) From: Kevin Traynor To: Pallantla Poornima Cc: Yipeng Wang , dpdk stable Date: Thu, 25 Apr 2019 16:40:27 +0100 Message-Id: <20190425154037.28778-52-ktraynor@redhat.com> In-Reply-To: <20190425154037.28778-1-ktraynor@redhat.com> References: <20190425154037.28778-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 25 Apr 2019 15:42:03 +0000 (UTC) Subject: [dpdk-stable] patch 'test/hash: replace sprintf with snprintf' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/01/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches can be viewed on the 18.11 branch at: https://github.com/kevintraynor/dpdk-stable-queue.git Thanks. Kevin Traynor --- >From 994a1345da0b6c33dc0e4a3cd2b1d89c31d2e848 Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Tue, 26 Mar 2019 10:27:23 +0000 Subject: [PATCH] test/hash: replace sprintf with snprintf [ upstream commit 8766e2a4782aecb6d474697617055e281149cc02 ] sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 473d1bebce ("hash: allow to store data in hash table") Signed-off-by: Pallantla Poornima Acked-by: Yipeng Wang --- test/test/test_hash_perf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c index 525211180..5648fce02 100644 --- a/test/test/test_hash_perf.c +++ b/test/test/test_hash_perf.c @@ -86,7 +86,9 @@ create_table(unsigned int with_data, unsigned int table_index, if (with_data) /* Table will store 8-byte data */ - sprintf(name, "test_hash%d_data", hashtest_key_lens[table_index]); + snprintf(name, sizeof(name), "test_hash%u_data", + hashtest_key_lens[table_index]); else - sprintf(name, "test_hash%d", hashtest_key_lens[table_index]); + snprintf(name, sizeof(name), "test_hash%u", + hashtest_key_lens[table_index]); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-04-25 16:37:48.990147635 +0100 +++ 0052-test-hash-replace-sprintf-with-snprintf.patch 2019-04-25 16:37:46.769294400 +0100 @@ -1 +1 @@ -From 8766e2a4782aecb6d474697617055e281149cc02 Mon Sep 17 00:00:00 2001 +From 994a1345da0b6c33dc0e4a3cd2b1d89c31d2e848 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8766e2a4782aecb6d474697617055e281149cc02 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -15 +16 @@ - app/test/test_hash_perf.c | 6 ++++-- + test/test/test_hash_perf.c | 6 ++++-- @@ -18 +19 @@ -diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c +diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c @@ -20,2 +21,2 @@ ---- a/app/test/test_hash_perf.c -+++ b/app/test/test_hash_perf.c +--- a/test/test/test_hash_perf.c ++++ b/test/test/test_hash_perf.c