From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 25094A0096 for ; Wed, 8 May 2019 12:17:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 183264C95; Wed, 8 May 2019 12:17:08 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9A1DD4C90 for ; Wed, 8 May 2019 12:17:06 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1094C301EA8F; Wed, 8 May 2019 10:17:06 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 363314123; Wed, 8 May 2019 10:17:05 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: dpdk stable Date: Wed, 8 May 2019 11:15:31 +0100 Message-Id: <20190508101534.8984-49-ktraynor@redhat.com> In-Reply-To: <20190508101534.8984-1-ktraynor@redhat.com> References: <20190508101534.8984-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 08 May 2019 10:17:06 +0000 (UTC) Subject: [dpdk-stable] patch 'raw/dpaa2_cmdif: fix warnings with GCC 9' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/13/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/4a1b3238788869011c4212c3d27c2d7dac771874 Thanks. Kevin Traynor --- >From 4a1b3238788869011c4212c3d27c2d7dac771874 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Wed, 1 May 2019 20:50:14 +0100 Subject: [PATCH] raw/dpaa2_cmdif: fix warnings with GCC 9 [ upstream commit a53f14f96112a0851a9c3788dd1e7b9d61c50191 ] GCC9 gives warnings if the parameter passed to printf for "%s" could be NULL, so we need to add checks in some cases to ensure that is not the case. Fixes: 3298fa4853b8 ("raw/dpaa2_cmdif: introduce DPAA2 command interface driver") Signed-off-by: Bruce Richardson --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c index 469960a3e..11951980f 100644 --- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c +++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c @@ -275,4 +275,6 @@ dpaa2_cmdif_remove(struct rte_vdev_device *vdev) name = rte_vdev_device_name(vdev); + if (name == NULL) + return -1; DPAA2_CMDIF_INFO("Closing %s on NUMA node %d", name, rte_socket_id()); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 11:05:08.244935731 +0100 +++ 0049-raw-dpaa2_cmdif-fix-warnings-with-GCC-9.patch 2019-05-08 11:05:05.859932134 +0100 @@ -1 +1 @@ -From a53f14f96112a0851a9c3788dd1e7b9d61c50191 Mon Sep 17 00:00:00 2001 +From 4a1b3238788869011c4212c3d27c2d7dac771874 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a53f14f96112a0851a9c3788dd1e7b9d61c50191 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 7d311b2ee..da3c7d7a6 100644 +index 469960a3e..11951980f 100644 @@ -22 +23 @@ -@@ -271,4 +271,6 @@ dpaa2_cmdif_remove(struct rte_vdev_device *vdev) +@@ -275,4 +275,6 @@ dpaa2_cmdif_remove(struct rte_vdev_device *vdev)