* [dpdk-stable] [PATCH 18.11 0/3] Fixes for GCC 9
@ 2019-05-16 18:21 Kevin Traynor
2019-05-16 18:21 ` [dpdk-stable] [PATCH 18.11 1/3] mk: disable warning for packed member pointer Kevin Traynor
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Kevin Traynor @ 2019-05-16 18:21 UTC (permalink / raw)
To: stable; +Cc: bruce.richardson, reshma.pattan, Kevin Traynor
Already there are some fixes from master in the 18.11 stable branch
to allow working with GCC 9. These are some additional fixes required.
Kevin Traynor (2):
bus/fslmc: fix warning with GCC 9
mk: disable packed member pointer warning for telemetry
Reshma Pattan (1):
mk: disable warning for packed member pointer
drivers/bus/fslmc/fslmc_bus.c | 2 +-
lib/librte_telemetry/Makefile | 5 +++++
mk/toolchain/gcc/rte.vars.mk | 3 +++
3 files changed, 9 insertions(+), 1 deletion(-)
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH 18.11 1/3] mk: disable warning for packed member pointer
2019-05-16 18:21 [dpdk-stable] [PATCH 18.11 0/3] Fixes for GCC 9 Kevin Traynor
@ 2019-05-16 18:21 ` Kevin Traynor
2019-05-16 18:21 ` [dpdk-stable] [PATCH 18.11 2/3] bus/fslmc: fix warning with GCC 9 Kevin Traynor
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Kevin Traynor @ 2019-05-16 18:21 UTC (permalink / raw)
To: stable; +Cc: bruce.richardson, reshma.pattan, David Marchand
From: Reshma Pattan <reshma.pattan@intel.com>
[ upstream commit a385972c3675dd2b4792ab5b3cf7a536e6f9846c ]
gcc 9 on Fedora 30 gives an error
"taking address of packed member may result in an
unaligned pointer value" warnings.
For clang builds this warning is already disabled,
so disable "-Waddress-of-packed-member" for gcc builds
also.
Snippet of build error:
lib/librte_eal/linux/eal/eal_memalloc.c: In function ‘alloc_seg_walk’:
lib/librte_eal/linux/eal/eal_memalloc.c:768:12: error:
taking address of packed member of ‘struct rte_mem_config’ may result
in an unaligned pointer value [-Werror=address-of-packed-member]
768 | cur_msl = &mcfg->memsegs[msl_idx];
| ^~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Tested-by: David Marchand <david.marchand@redhat.com>
---
mk/toolchain/gcc/rte.vars.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk
index d8b99faf6..b852fcfd7 100644
--- a/mk/toolchain/gcc/rte.vars.mk
+++ b/mk/toolchain/gcc/rte.vars.mk
@@ -88,4 +88,7 @@ WERROR_FLAGS += -Wno-format-truncation
endif
+# disable packed member unalign warnings
+WERROR_FLAGS += -Wno-address-of-packed-member
+
export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF
export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH 18.11 2/3] bus/fslmc: fix warning with GCC 9
2019-05-16 18:21 [dpdk-stable] [PATCH 18.11 0/3] Fixes for GCC 9 Kevin Traynor
2019-05-16 18:21 ` [dpdk-stable] [PATCH 18.11 1/3] mk: disable warning for packed member pointer Kevin Traynor
@ 2019-05-16 18:21 ` Kevin Traynor
2019-05-16 18:21 ` [dpdk-stable] [PATCH 18.11 3/3] mk: disable packed member pointer warning for telemetry Kevin Traynor
2019-05-17 8:39 ` [dpdk-stable] [PATCH 18.11 0/3] Fixes for GCC 9 Richardson, Bruce
3 siblings, 0 replies; 6+ messages in thread
From: Kevin Traynor @ 2019-05-16 18:21 UTC (permalink / raw)
To: stable; +Cc: bruce.richardson, reshma.pattan, Kevin Traynor
Printing a null pointer with %s is flagged as a warning by GCC 9, and
should not be done. Replace the %s with the word "null" itself.
This is an additional GCC 9 fix required for dpdk-stable.
Fixes: 50245be05d1a ("bus/fslmc: support device blacklisting")
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
drivers/bus/fslmc/fslmc_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index 9ee1bf862..776b7caad 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -253,5 +253,5 @@ rte_fslmc_parse(const char *name, void *addr)
t_ptr = strchr(name, '.');
if (!t_ptr) {
- DPAA2_BUS_ERR("Incorrect device string observed (%s)", t_ptr);
+ DPAA2_BUS_ERR("Incorrect device string observed (null)");
goto err_out;
}
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH 18.11 3/3] mk: disable packed member pointer warning for telemetry
2019-05-16 18:21 [dpdk-stable] [PATCH 18.11 0/3] Fixes for GCC 9 Kevin Traynor
2019-05-16 18:21 ` [dpdk-stable] [PATCH 18.11 1/3] mk: disable warning for packed member pointer Kevin Traynor
2019-05-16 18:21 ` [dpdk-stable] [PATCH 18.11 2/3] bus/fslmc: fix warning with GCC 9 Kevin Traynor
@ 2019-05-16 18:21 ` Kevin Traynor
2019-05-17 8:39 ` [dpdk-stable] [PATCH 18.11 0/3] Fixes for GCC 9 Richardson, Bruce
3 siblings, 0 replies; 6+ messages in thread
From: Kevin Traynor @ 2019-05-16 18:21 UTC (permalink / raw)
To: stable; +Cc: bruce.richardson, reshma.pattan, Kevin Traynor
Warnings for packed member pointers were disabled for GCC 9.
There was 2 in telemetry that were missed, as it doesn't use
WERROR_FLAGS.
Fixes: a385972c3675 ("mk: disable warning for packed member pointer")
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
lib/librte_telemetry/Makefile | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/librte_telemetry/Makefile b/lib/librte_telemetry/Makefile
index 1a0506913..ef73a4e73 100644
--- a/lib/librte_telemetry/Makefile
+++ b/lib/librte_telemetry/Makefile
@@ -20,4 +20,9 @@ EXPORT_MAP := rte_telemetry_version.map
LIBABIVER := 1
+ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
+CFLAGS_rte_telemetry.o += -Wno-address-of-packed-member
+CFLAGS_rte_telemetry_parser.o += -Wno-address-of-packed-member
+endif
+
# library source files
SRCS-$(CONFIG_RTE_LIBRTE_TELEMETRY) := rte_telemetry.c
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH 18.11 0/3] Fixes for GCC 9
2019-05-16 18:21 [dpdk-stable] [PATCH 18.11 0/3] Fixes for GCC 9 Kevin Traynor
` (2 preceding siblings ...)
2019-05-16 18:21 ` [dpdk-stable] [PATCH 18.11 3/3] mk: disable packed member pointer warning for telemetry Kevin Traynor
@ 2019-05-17 8:39 ` Richardson, Bruce
2019-05-20 16:24 ` Kevin Traynor
3 siblings, 1 reply; 6+ messages in thread
From: Richardson, Bruce @ 2019-05-17 8:39 UTC (permalink / raw)
To: Kevin Traynor, stable; +Cc: Pattan, Reshma
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Thursday, May 16, 2019 7:22 PM
> To: stable@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; Kevin Traynor <ktraynor@redhat.com>
> Subject: [PATCH 18.11 0/3] Fixes for GCC 9
>
> Already there are some fixes from master in the 18.11 stable branch to
> allow working with GCC 9. These are some additional fixes required.
>
> Kevin Traynor (2):
> bus/fslmc: fix warning with GCC 9
> mk: disable packed member pointer warning for telemetry
>
> Reshma Pattan (1):
> mk: disable warning for packed member pointer
>
> drivers/bus/fslmc/fslmc_bus.c | 2 +-
> lib/librte_telemetry/Makefile | 5 +++++ mk/toolchain/gcc/rte.vars.mk |
> 3 +++
> 3 files changed, 9 insertions(+), 1 deletion(-)
>
> --
> 2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH 18.11 0/3] Fixes for GCC 9
2019-05-17 8:39 ` [dpdk-stable] [PATCH 18.11 0/3] Fixes for GCC 9 Richardson, Bruce
@ 2019-05-20 16:24 ` Kevin Traynor
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Traynor @ 2019-05-20 16:24 UTC (permalink / raw)
To: Richardson, Bruce, stable; +Cc: Pattan, Reshma
On 17/05/2019 09:39, Richardson, Bruce wrote:
> Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
>> -----Original Message-----
>> From: Kevin Traynor [mailto:ktraynor@redhat.com]
>> Sent: Thursday, May 16, 2019 7:22 PM
>> To: stable@dpdk.org
>> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Pattan, Reshma
>> <reshma.pattan@intel.com>; Kevin Traynor <ktraynor@redhat.com>
>> Subject: [PATCH 18.11 0/3] Fixes for GCC 9
>>
>> Already there are some fixes from master in the 18.11 stable branch to
>> allow working with GCC 9. These are some additional fixes required.
>>
>> Kevin Traynor (2):
>> bus/fslmc: fix warning with GCC 9
>> mk: disable packed member pointer warning for telemetry
>>
>> Reshma Pattan (1):
>> mk: disable warning for packed member pointer
>>
>> drivers/bus/fslmc/fslmc_bus.c | 2 +-
>> lib/librte_telemetry/Makefile | 5 +++++ mk/toolchain/gcc/rte.vars.mk |
>> 3 +++
>> 3 files changed, 9 insertions(+), 1 deletion(-)
>>
>> --
>> 2.20.1
>
Thanks, applied
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-20 16:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-16 18:21 [dpdk-stable] [PATCH 18.11 0/3] Fixes for GCC 9 Kevin Traynor
2019-05-16 18:21 ` [dpdk-stable] [PATCH 18.11 1/3] mk: disable warning for packed member pointer Kevin Traynor
2019-05-16 18:21 ` [dpdk-stable] [PATCH 18.11 2/3] bus/fslmc: fix warning with GCC 9 Kevin Traynor
2019-05-16 18:21 ` [dpdk-stable] [PATCH 18.11 3/3] mk: disable packed member pointer warning for telemetry Kevin Traynor
2019-05-17 8:39 ` [dpdk-stable] [PATCH 18.11 0/3] Fixes for GCC 9 Richardson, Bruce
2019-05-20 16:24 ` Kevin Traynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).