From: Ye Xiaolong <xiaolong.ye@intel.com>
To: "Zhang, Tianfei" <tianfei.zhang@intel.com>
Cc: dev@dpdk.org, rosen.xu@intel.com, stable@dpdk.org, Zhang@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 2/2] raw/ifpga: fix logically dead code
Date: Tue, 4 Jun 2019 15:26:46 +0800 [thread overview]
Message-ID: <20190604072646.GB94383@intel.com> (raw)
In-Reply-To: <20190604135148.21791-2-tianfei.zhang@intel.com>
On 06/04, Zhang, Tianfei wrote:
>add temporary variable in max10_reg_write().
>
>Coverity issue: 337927
>Cc: stable@dpdk.org
Missing a Fixes line?
>
>Signed-off-by: Zhang, Tianfei <tianfei.zhang@intel.com>
>---
> drivers/raw/ifpga_rawdev/base/opae_intel_max10.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c b/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c
>index f354ee4b6..3ff6575d7 100644
>--- a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c
>+++ b/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c
>@@ -17,11 +17,13 @@ int max10_reg_read(unsigned int reg, unsigned int *val)
>
> int max10_reg_write(unsigned int reg, unsigned int val)
> {
>+ unsigned int tmp = val;
>+
> if (!g_max10)
> return -ENODEV;
>
> return spi_transaction_write(g_max10->spi_tran_dev,
>- reg, 4, (unsigned char *)&val);
>+ reg, 4, (unsigned char *)&tmp);
> }
>
> struct intel_max10_device *
>@@ -57,7 +59,7 @@ intel_max10_device_probe(struct altera_spi_device *spi,
>
> /* set PKVL Polling manually in BBS */
> ret = max10_reg_write(PKVL_POLLING_CTRL, 0x3);
>- if (ret) {
>+ if (ret != 0) {
> dev_err(dev, "%s set PKVL polling fail\n", __func__);
> goto spi_tran_fail;
> }
>--
>2.17.1
>
next prev parent reply other threads:[~2019-06-04 7:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 13:51 [dpdk-stable] [PATCH v1 1/2] raw/ifpga: fix use of untrusted scalar value Zhang, Tianfei
2019-06-04 7:29 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-06-04 8:03 ` Zhang, Tianfei
2019-06-04 13:51 ` [dpdk-stable] [PATCH v1 2/2] raw/ifpga: fix logically dead code Zhang, Tianfei
2019-06-04 7:26 ` Ye Xiaolong [this message]
2019-06-04 9:06 ` [dpdk-stable] [dpdk-dev] " Mcnamara, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604072646.GB94383@intel.com \
--to=xiaolong.ye@intel.com \
--cc=Zhang@dpdk.org \
--cc=dev@dpdk.org \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).