From: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Cc: dev@dpdk.org, Herakliusz Lipiec <herakliusz.lipiec@intel.com>,
anatoly.burakov@intel.com, stable@dpdk.org
Subject: [dpdk-stable] [PATCH v2] app/test: fix autotest_runner crash
Date: Wed, 12 Jun 2019 15:46:47 +0100 [thread overview]
Message-ID: <20190612144647.26850-1-herakliusz.lipiec@intel.com> (raw)
In-Reply-To: <20190612133323.43530-1-herakliusz.lipiec@intel.com>
On some systems when dpdk test is executed with make test command
autotest_runner crashes in first_cpu_on_node. This happens when list
of available cpus contains something that is not a cpu as first element.
Fixed by removing all non-cpu values from list of available cpus.
Bugzilla ID: 253
Fixes: 22dcd9a4d90f ("test: parallelize unit tests")
Cc: anatoly.burakov@intel.com
Cc: stable@dpdk.org
Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
---
app/test/autotest_runner.py | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/app/test/autotest_runner.py b/app/test/autotest_runner.py
index b72716e1e..95e74c760 100644
--- a/app/test/autotest_runner.py
+++ b/app/test/autotest_runner.py
@@ -43,9 +43,16 @@ def get_numa_nodes():
# find first (or any, really) CPU on a particular node, will be used to spread
# processes around NUMA nodes to avoid exhausting memory on particular node
def first_cpu_on_node(node_nr):
- cpu_path = glob.glob("/sys/devices/system/node/node%d/cpu*" % node_nr)[0]
- cpu_name = os.path.basename(cpu_path)
- m = re.match(r"cpu(\d+)", cpu_name)
+ cpu_path = glob.glob("/sys/devices/system/node/node%d/cpu*" % node_nr)
+ r = re.compile(r"cpu(\d+)")
+ cpu_name = filter(None,
+ map(r.match,
+ map(os.path.basename, cpu_path)
+ )
+ )
+ # for compatibility between python 3 and 2 we need to make interable out
+ # of filter return as it returns list in python 2 and a generator in 3
+ m = next(iter(cpu_name))
return int(m.group(1))
--
2.17.2
next prev parent reply other threads:[~2019-06-12 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 13:33 [dpdk-stable] [PATCH] " Herakliusz Lipiec
2019-06-12 14:18 ` Burakov, Anatoly
2019-06-12 14:46 ` Herakliusz Lipiec [this message]
2019-06-12 14:48 ` [dpdk-stable] [PATCH v2] " Burakov, Anatoly
2019-07-04 21:19 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612144647.26850-1-herakliusz.lipiec@intel.com \
--to=herakliusz.lipiec@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).