[dpdk-stable] [PATCH 1/2] compose-notice: update compose-notice text

[dpdk-stable] [PATCH 1/2] compose-notice: update compose-notice text

[Kevin Traynor]

I got some feedback that it was confusing, so added a little
text to explicitly mention that changes would be from rebasing.

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 compose-notice | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/compose-notice b/compose-notice
index 21cbc68..e44c738 100644
--- a/compose-notice
+++ b/compose-notice
@@ -43,7 +43,9 @@ It will be pushed if I get no objections before $(date --date="+2 days" "+%D").
 shout if anyone has objections.
 $(cat notice-more 2>/dev/null | grep -v "^#")
-Also note that after the patch there's a diff of the upstream commit vs the patch applied
-to the branch. If the code is different (ie: not only metadata diffs), due for example to
-a change in context or macro names, please double check it.
+Also note that after the patch there's a diff of the upstream commit vs the
+patch applied to the branch. This will indicate if there was any rebasing
+needed to apply to the stable branch. If there were code changes for rebasing
+(ie: not only metadata diffs), please double check that the rebase was
+correctly done.
 
 EOF
-- 
2.20.1

[dpdk-stable] [PATCH 2/2] 5-make-release-commit: Update release notes

[Kevin Traynor]

Add a seperate section in the release notes for each
LTS/stable minor release. It will include the fixes/validation
information along with newly added sections for known issues
and skipped patches.

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 5-make-release-commit | 22 +++++++++++++++++-----
 README                |  2 ++
 2 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/5-make-release-commit b/5-make-release-commit
index 84e8a21..522b46b 100755
--- a/5-make-release-commit
+++ b/5-make-release-commit
@@ -22,9 +22,7 @@ update_release_note()
 	{
 
-	if [ $RTE_VER_MINOR -eq 1 ]; then
-		echo
-		echo "Fixes and Validation in $RTE_VER_MAJOR Stable Release"
-		echo "--------------------------------------------"
-	fi
+	echo
+	echo "$stable_release Release Notes"
+	echo "---------------------"
 
 	echo
@@ -42,4 +40,18 @@ update_release_note()
 	echo "$(cat $stable_release/validation)"
 
+        echo
+        echo "$stable_release Known Issues"
+        echo "~~~~~~~~~~~~~~~~~~~~"
+        echo
+
+	echo "$(cat $stable_release/known_issues)"
+
+        echo
+        echo "Fixes skipped and status unresolved"
+        echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
+        echo
+
+	echo "$(cat $stable_release/failed_list)"
+
 	} >> $DPDK_DIR/doc/guides/rel_notes/release_${RTE_VER_MAJOR/./_}.rst
 }
diff --git a/README b/README
index ec9c899..5eaefd2 100644
--- a/README
+++ b/README
@@ -142,4 +142,6 @@ does:
 - update the release note with the bug fixing commits
 - update the release note with the validation from the 'validation' file
+- update the release note with known issues from the 'known_issues' file
+- update the release note with skipped patches from the 'failed_list' file
 - commit above changes with a short commit log ("release $stable_release")
 
-- 
2.20.1

Re: [dpdk-stable] [PATCH 1/2] compose-notice: update compose-notice text

[Luca Boccassi]

On Fri, 2019-06-21 at 15:40 +0100, Kevin Traynor wrote:
> I got some feedback that it was confusing, so added a little
> text to explicitly mention that changes would be from rebasing.
> 
> Signed-off-by: Kevin Traynor <
> ktraynor@redhat.com
> >
> ---
>  compose-notice | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/compose-notice b/compose-notice
> index 21cbc68..e44c738 100644
> --- a/compose-notice
> +++ b/compose-notice
> @@ -43,7 +43,9 @@ It will be pushed if I get no objections before
> $(date --date="+2 days" "+%D").
>  shout if anyone has objections.
>  $(cat notice-more 2>/dev/null | grep -v "^#")
> -Also note that after the patch there's a diff of the upstream commit
> vs the patch applied
> -to the branch. If the code is different (ie: not only metadata
> diffs), due for example to
> -a change in context or macro names, please double check it.
> +Also note that after the patch there's a diff of the upstream commit
> vs the
> +patch applied to the branch. This will indicate if there was any
> rebasing
> +needed to apply to the stable branch. If there were code changes for
> rebasing
> +(ie: not only metadata diffs), please double check that the rebase
> was
> +correctly done.
>  
>  EOF

Acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-stable] [PATCH 2/2] 5-make-release-commit: Update release notes

[Luca Boccassi]

On Fri, 2019-06-21 at 15:40 +0100, Kevin Traynor wrote:
> Add a seperate section in the release notes for each
> LTS/stable minor release. It will include the fixes/validation
> information along with newly added sections for known issues
> and skipped patches.
> 
> Signed-off-by: Kevin Traynor <
> ktraynor@redhat.com
> >
> ---
>  5-make-release-commit | 22 +++++++++++++++++-----
>  README                |  2 ++
>  2 files changed, 19 insertions(+), 5 deletions(-)
> 
> diff --git a/5-make-release-commit b/5-make-release-commit
> index 84e8a21..522b46b 100755
> --- a/5-make-release-commit
> +++ b/5-make-release-commit
> @@ -22,9 +22,7 @@ update_release_note()
>  	{
>  
> -	if [ $RTE_VER_MINOR -eq 1 ]; then
> -		echo
> -		echo "Fixes and Validation in $RTE_VER_MAJOR Stable
> Release"
> -		echo "--------------------------------------------"
> -	fi
> +	echo
> +	echo "$stable_release Release Notes"
> +	echo "---------------------"
>  
>  	echo
> @@ -42,4 +40,18 @@ update_release_note()
>  	echo "$(cat $stable_release/validation)"
>  
> +        echo
> +        echo "$stable_release Known Issues"
> +        echo "~~~~~~~~~~~~~~~~~~~~"
> +        echo
> +
> +	echo "$(cat $stable_release/known_issues)"
> +
> +        echo
> +        echo "Fixes skipped and status unresolved"
> +        echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
> +        echo
> +
> +	echo "$(cat $stable_release/failed_list)"
> +
>  	} >>
> $DPDK_DIR/doc/guides/rel_notes/release_${RTE_VER_MAJOR/./_}.rst
>  }
> diff --git a/README b/README
> index ec9c899..5eaefd2 100644
> --- a/README
> +++ b/README
> @@ -142,4 +142,6 @@ does:
>  - update the release note with the bug fixing commits
>  - update the release note with the validation from the 'validation'
> file
> +- update the release note with known issues from the 'known_issues'
> file
> +- update the release note with skipped patches from the
> 'failed_list' file
>  - commit above changes with a short commit log ("release
> $stable_release")

Acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi