From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6A13DA0471 for ; Fri, 21 Jun 2019 18:50:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60ED91D54F; Fri, 21 Jun 2019 18:50:46 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A10471D54F for ; Fri, 21 Jun 2019 18:50:45 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 254728F91B for ; Fri, 21 Jun 2019 16:50:45 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-77.ams2.redhat.com [10.36.117.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5411360BE0; Fri, 21 Jun 2019 16:50:31 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Maxime Coquelin , dpdk stable Date: Fri, 21 Jun 2019 17:46:04 +0100 Message-Id: <20190621164626.31219-20-ktraynor@redhat.com> In-Reply-To: <20190621164626.31219-1-ktraynor@redhat.com> References: <20190621164626.31219-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 21 Jun 2019 16:50:45 +0000 (UTC) Subject: [dpdk-stable] patch 'examples/qos_sched: do not dereference global config struct' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/26/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/54c7559ddb79371772ec173f233fea6a6204dc98 Thanks. Kevin Traynor --- >From 54c7559ddb79371772ec173f233fea6a6204dc98 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 15 May 2019 09:54:22 +0200 Subject: [PATCH] examples/qos_sched: do not dereference global config struct [ upstream commit 4df7d46bbdba4f390816476fa62f21668f87b995 ] Prefer the existing apis rather than direct access the configuration structure. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: David Marchand Reviewed-by: Maxime Coquelin --- examples/qos_sched/args.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c index 83eee95cc..7431b2981 100644 --- a/examples/qos_sched/args.c +++ b/examples/qos_sched/args.c @@ -91,14 +91,13 @@ static uint64_t app_eal_core_mask(void) { - uint32_t i; uint64_t cm = 0; - struct rte_config *cfg = rte_eal_get_configuration(); + uint32_t i; for (i = 0; i < APP_MAX_LCORE; i++) { - if (cfg->lcore_role[i] == ROLE_RTE) + if (rte_lcore_has_role(i, ROLE_RTE)) cm |= (1ULL << i); } - cm |= (1ULL << cfg->master_lcore); + cm |= (1ULL << rte_get_master_lcore()); return cm; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-06-21 17:22:12.792821906 +0100 +++ 0020-examples-qos_sched-do-not-dereference-global-config-.patch 2019-06-21 17:22:11.731518943 +0100 @@ -1 +1 @@ -From 4df7d46bbdba4f390816476fa62f21668f87b995 Mon Sep 17 00:00:00 2001 +From 54c7559ddb79371772ec173f233fea6a6204dc98 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4df7d46bbdba4f390816476fa62f21668f87b995 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org