From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 946B1A0471 for ; Fri, 21 Jun 2019 18:47:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 89E3E1D564; Fri, 21 Jun 2019 18:47:19 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id E35691D564 for ; Fri, 21 Jun 2019 18:47:17 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 613FA30C31A1; Fri, 21 Jun 2019 16:47:17 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-77.ams2.redhat.com [10.36.117.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id 93EED60BE0; Fri, 21 Jun 2019 16:47:12 +0000 (UTC) From: Kevin Traynor To: Yunjian Wang Cc: Wei Zhao , dpdk stable Date: Fri, 21 Jun 2019 17:45:47 +0100 Message-Id: <20190621164626.31219-3-ktraynor@redhat.com> In-Reply-To: <20190621164626.31219-1-ktraynor@redhat.com> References: <20190621164626.31219-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 21 Jun 2019 16:47:17 +0000 (UTC) Subject: [dpdk-stable] patch 'net/ixgbe: fix unexpected link handler' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/26/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/f19610f8d2b667b5dacd14fc619b986cb2b32a31 Thanks. Kevin Traynor --- >From f19610f8d2b667b5dacd14fc619b986cb2b32a31 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Wed, 8 May 2019 20:51:38 +0800 Subject: [PATCH] net/ixgbe: fix unexpected link handler [ upstream commit 03bb633aa86232df29a0692b2727cff3e4e1b685 ] The nic's interrupt source has some active handler, which maybe call ixgbe_dev_link_update() to set link handler. We should cancel the link handler before remove dev to prevent executing the link handler. It triggers segfault. Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update") Signed-off-by: Yunjian Wang Acked-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index e9533e5a1..6341c1a3e 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -1340,4 +1340,7 @@ eth_ixgbe_dev_uninit(struct rte_eth_dev *eth_dev) rte_eal_alarm_cancel(ixgbe_dev_interrupt_delayed_handler, eth_dev); + /* cancel the link handler before remove dev */ + rte_eal_alarm_cancel(ixgbe_dev_setup_link_alarm_handler, eth_dev); + /* uninitialize PF if max_vfs not zero */ ixgbe_pf_host_uninit(eth_dev); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-06-21 17:22:11.901814697 +0100 +++ 0003-net-ixgbe-fix-unexpected-link-handler.patch 2019-06-21 17:22:11.704519558 +0100 @@ -1 +1 @@ -From 03bb633aa86232df29a0692b2727cff3e4e1b685 Mon Sep 17 00:00:00 2001 +From f19610f8d2b667b5dacd14fc619b986cb2b32a31 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 03bb633aa86232df29a0692b2727cff3e4e1b685 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 975fa474c..2470c89cf 100644 +index e9533e5a1..6341c1a3e 100644 @@ -24 +25 @@ -@@ -1345,4 +1345,7 @@ eth_ixgbe_dev_uninit(struct rte_eth_dev *eth_dev) +@@ -1340,4 +1340,7 @@ eth_ixgbe_dev_uninit(struct rte_eth_dev *eth_dev)