From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E4EDAA046B for ; Mon, 24 Jun 2019 17:26:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C857C1BEE9; Mon, 24 Jun 2019 17:26:57 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C69A31BED9 for ; Mon, 24 Jun 2019 17:26:56 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4326B3087926; Mon, 24 Jun 2019 15:26:56 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-250.ams2.redhat.com [10.36.116.250]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A3E619C69; Mon, 24 Jun 2019 15:26:54 +0000 (UTC) From: Kevin Traynor To: Somnath Kotur Cc: Kalesh AP , Ajit Khaparde , dpdk stable Date: Mon, 24 Jun 2019 16:25:01 +0100 Message-Id: <20190624152525.19349-37-ktraynor@redhat.com> In-Reply-To: <20190624152525.19349-1-ktraynor@redhat.com> References: <20190624152525.19349-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 24 Jun 2019 15:26:56 +0000 (UTC) Subject: [dpdk-stable] patch 'net/bnxt: check for null completion ring doorbell' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/0e449f4f13ad7d9c8ff1c241a51b5d41cd03d245 Thanks. Kevin Traynor --- >From 0e449f4f13ad7d9c8ff1c241a51b5d41cd03d245 Mon Sep 17 00:00:00 2001 From: Somnath Kotur Date: Sat, 8 Jun 2019 23:22:04 +0400 Subject: [PATCH] net/bnxt: check for null completion ring doorbell [ upstream commit 2807c5861e31b99295b915b28e121ce059a46416 ] It is observed that sometimes during init, the bnxt_int_handler() gets invoked while the cpr->cp_db.doorbell is not yet initialized. Check for the same and return. Fixes: f7ecea911ec5 ("net/bnxt: fix interrupt handler") Signed-off-by: Somnath Kotur Signed-off-by: Kalesh AP Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c index e03766b41..e3aac7cbe 100644 --- a/drivers/net/bnxt/bnxt_irq.c +++ b/drivers/net/bnxt/bnxt_irq.c @@ -32,5 +32,5 @@ static void bnxt_int_handler(void *param) raw_cons = cpr->cp_raw_cons; while (1) { - if (!cpr || !cpr->cp_ring_struct) + if (!cpr || !cpr->cp_ring_struct || !cpr->cp_doorbell) return; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-06-24 16:18:56.998750420 +0100 +++ 0037-net-bnxt-check-for-null-completion-ring-doorbell.patch 2019-06-24 16:18:55.067430374 +0100 @@ -1 +1 @@ -From 2807c5861e31b99295b915b28e121ce059a46416 Mon Sep 17 00:00:00 2001 +From 0e449f4f13ad7d9c8ff1c241a51b5d41cd03d245 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2807c5861e31b99295b915b28e121ce059a46416 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 918f3dcf4..0bb3eb4fa 100644 +index e03766b41..e3aac7cbe 100644 @@ -28 +29 @@ -+ if (!cpr || !cpr->cp_ring_struct || !cpr->cp_db.doorbell) ++ if (!cpr || !cpr->cp_ring_struct || !cpr->cp_doorbell)