From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8D5AFA046B for ; Mon, 24 Jun 2019 17:27:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 81BA41BE55; Mon, 24 Jun 2019 17:27:31 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C3B831BE55 for ; Mon, 24 Jun 2019 17:27:29 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 40CD7308FEDF; Mon, 24 Jun 2019 15:27:29 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-250.ams2.redhat.com [10.36.116.250]) by smtp.corp.redhat.com (Postfix) with ESMTP id B7C5919C6A; Mon, 24 Jun 2019 15:27:23 +0000 (UTC) From: Kevin Traynor To: Reshma Pattan Cc: Kevin Laatz , dpdk stable Date: Mon, 24 Jun 2019 16:25:08 +0100 Message-Id: <20190624152525.19349-44-ktraynor@redhat.com> In-Reply-To: <20190624152525.19349-1-ktraynor@redhat.com> References: <20190624152525.19349-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Mon, 24 Jun 2019 15:27:29 +0000 (UTC) Subject: [dpdk-stable] patch 'telemetry: fix memory leak' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/e3148f5708756722b6bcd4125a77f080f1593247 Thanks. Kevin Traynor --- >From e3148f5708756722b6bcd4125a77f080f1593247 Mon Sep 17 00:00:00 2001 From: Reshma Pattan Date: Wed, 29 May 2019 13:43:17 +0100 Subject: [PATCH] telemetry: fix memory leak [ upstream commit 05682bddb603fad361836a3045328a0079601469 ] Free the `values` pointer before returning from rte_telemetry_command_ports_all_stat_values() to avoid memory leak. Fixes: c12cefa379 ("telemetry: fix mapping of statistics") Signed-off-by: Reshma Pattan Acked-by: Kevin Laatz --- lib/librte_telemetry/rte_telemetry_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_telemetry/rte_telemetry_parser.c b/lib/librte_telemetry/rte_telemetry_parser.c index 9bc16eef4..e9297021a 100644 --- a/lib/librte_telemetry/rte_telemetry_parser.c +++ b/lib/librte_telemetry/rte_telemetry_parser.c @@ -343,4 +343,5 @@ rte_telemetry_command_ports_all_stat_values(struct telemetry_impl *telemetry, } + free(values); return 0; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-06-24 16:18:57.352322936 +0100 +++ 0044-telemetry-fix-memory-leak.patch 2019-06-24 16:18:55.088429878 +0100 @@ -1 +1 @@ -From 05682bddb603fad361836a3045328a0079601469 Mon Sep 17 00:00:00 2001 +From e3148f5708756722b6bcd4125a77f080f1593247 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 05682bddb603fad361836a3045328a0079601469 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org