* [dpdk-stable] [PATCH v2] net/ice: fix flow validation fail issue
@ 2019-07-12 1:34 Qiming Yang
2019-07-12 8:49 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
0 siblings, 1 reply; 2+ messages in thread
From: Qiming Yang @ 2019-07-12 1:34 UTC (permalink / raw)
To: dev; +Cc: Qiming Yang, stable
The return value of function ice_flow_valid_attr should
be non-zero. This patch fixed this issue.
Fixes: d76116a4678f ("net/ice: add generic flow API")
Cc: stable@dpdk.org
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/ice/ice_generic_flow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c
index d5ff278..e6a2c4b 100644
--- a/drivers/net/ice/ice_generic_flow.c
+++ b/drivers/net/ice/ice_generic_flow.c
@@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev,
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION,
actions, "Invalid queue ID for"
- " ethertype_filter.");
+ " switch filter.");
return -rte_errno;
}
break;
@@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev,
}
ret = ice_flow_valid_attr(attr, error);
- if (!ret)
+ if (ret)
return ret;
inset = ice_flow_valid_pattern(pattern, error);
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/ice: fix flow validation fail issue
2019-07-12 1:34 [dpdk-stable] [PATCH v2] net/ice: fix flow validation fail issue Qiming Yang
@ 2019-07-12 8:49 ` Ye Xiaolong
0 siblings, 0 replies; 2+ messages in thread
From: Ye Xiaolong @ 2019-07-12 8:49 UTC (permalink / raw)
To: Qiming Yang; +Cc: dev, stable
Hi, qiming
On 07/12, Qiming Yang wrote:
>The return value of function ice_flow_valid_attr should
>be non-zero. This patch fixed this issue.
>
Minor nit about the title, 'issue' is never needed after word 'fix', what about
net/ice: fix flow validation failure ?
And for the commit log, it's unclear to me, I think what you want to say is
function ice_flow_valid_attr will return a negative value on error, right?
>Fixes: d76116a4678f ("net/ice: add generic flow API")
>Cc: stable@dpdk.org
>
>Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>---
> drivers/net/ice/ice_generic_flow.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c
>index d5ff278..e6a2c4b 100644
>--- a/drivers/net/ice/ice_generic_flow.c
>+++ b/drivers/net/ice/ice_generic_flow.c
>@@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev,
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION,
> actions, "Invalid queue ID for"
>- " ethertype_filter.");
>+ " switch filter.");
> return -rte_errno;
> }
> break;
>@@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev,
> }
>
> ret = ice_flow_valid_attr(attr, error);
>- if (!ret)
>+ if (ret)
> return ret;
>
> inset = ice_flow_valid_pattern(pattern, error);
>--
>2.7.4
>
For the patch,
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-12 2:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-12 1:34 [dpdk-stable] [PATCH v2] net/ice: fix flow validation fail issue Qiming Yang
2019-07-12 8:49 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).