* [dpdk-stable] [PATCH 3/7] net/bnxt: fix receive interrupt vector
[not found] <20190719061906.42451-1-ajit.khaparde@broadcom.com>
@ 2019-07-19 6:19 ` Ajit Khaparde
2019-07-19 6:19 ` [dpdk-stable] [PATCH 4/7] net/bnxt: fix interrupt rearm logic Ajit Khaparde
2019-07-19 6:19 ` [dpdk-stable] [PATCH 6/7] net/bnxt: remove unnecessary interrupt disable Ajit Khaparde
2 siblings, 0 replies; 3+ messages in thread
From: Ajit Khaparde @ 2019-07-19 6:19 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Stephen Hemminger, stable, Rahul Gupta
From: Stephen Hemminger <stephen@networkplumber.org>
The receive interrupt vector should be offset by the constant
RTE_INTR_VEC_RXTX_OFFSET; otherwise setting up some queue interrupts
will fail.
Fixes: 1fe427fd08ee ("net/bnxt: support enable/disable interrupt")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Tested-by: Rahul Gupta <rahul.gupta@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 6492f5627..fec1ecbae 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -427,7 +427,8 @@ static int bnxt_init_chip(struct bnxt *bp)
intr_handle->max_intr);
for (queue_id = 0; queue_id < bp->eth_dev->data->nb_rx_queues;
queue_id++) {
- intr_handle->intr_vec[queue_id] = vec;
+ intr_handle->intr_vec[queue_id] =
+ vec + BNXT_RX_VEC_START;
if (vec < base + intr_handle->nb_efd - 1)
vec++;
}
--
2.20.1 (Apple Git-117)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-stable] [PATCH 4/7] net/bnxt: fix interrupt rearm logic
[not found] <20190719061906.42451-1-ajit.khaparde@broadcom.com>
2019-07-19 6:19 ` [dpdk-stable] [PATCH 3/7] net/bnxt: fix receive interrupt vector Ajit Khaparde
@ 2019-07-19 6:19 ` Ajit Khaparde
2019-07-19 6:19 ` [dpdk-stable] [PATCH 6/7] net/bnxt: remove unnecessary interrupt disable Ajit Khaparde
2 siblings, 0 replies; 3+ messages in thread
From: Ajit Khaparde @ 2019-07-19 6:19 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Rahul Gupta, stable
From: Rahul Gupta <rahul.gupta@broadcom.com>
Rearm will intimate hardware that current interrupts are processed
and it can continue to send more.
Fixes: 1fe427fd08ee ("net/bnxt: support enable/disable interrupt")
Cc: stable@dpdk.org
Signed-off-by: Rahul Gupta <rahul.gupta@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_rxq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index c94cac5a9..e0eb890f8 100644
--- a/drivers/net/bnxt/bnxt_rxq.c
+++ b/drivers/net/bnxt/bnxt_rxq.c
@@ -374,7 +374,7 @@ bnxt_rx_queue_intr_enable_op(struct rte_eth_dev *eth_dev, uint16_t queue_id)
return rc;
}
cpr = rxq->cp_ring;
- B_CP_DB_ARM(cpr);
+ B_CP_DB_REARM(cpr, cpr->cp_raw_cons);
}
return rc;
}
--
2.20.1 (Apple Git-117)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-stable] [PATCH 6/7] net/bnxt: remove unnecessary interrupt disable
[not found] <20190719061906.42451-1-ajit.khaparde@broadcom.com>
2019-07-19 6:19 ` [dpdk-stable] [PATCH 3/7] net/bnxt: fix receive interrupt vector Ajit Khaparde
2019-07-19 6:19 ` [dpdk-stable] [PATCH 4/7] net/bnxt: fix interrupt rearm logic Ajit Khaparde
@ 2019-07-19 6:19 ` Ajit Khaparde
2 siblings, 0 replies; 3+ messages in thread
From: Ajit Khaparde @ 2019-07-19 6:19 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, stable, Kalesh AP
Remove an unnecessary rte_intr_disable() call to disable interrupt
during device init.
Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update operations")
Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index d6176a686..357ec830d 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -248,9 +248,6 @@ static int bnxt_init_chip(struct bnxt *bp)
unsigned int i, j;
int rc;
- /* disable uio/vfio intr/eventfd mapping */
- rte_intr_disable(intr_handle);
-
if (bp->eth_dev->data->mtu > RTE_ETHER_MTU) {
bp->eth_dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_JUMBO_FRAME;
--
2.20.1 (Apple Git-117)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-19 6:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190719061906.42451-1-ajit.khaparde@broadcom.com>
2019-07-19 6:19 ` [dpdk-stable] [PATCH 3/7] net/bnxt: fix receive interrupt vector Ajit Khaparde
2019-07-19 6:19 ` [dpdk-stable] [PATCH 4/7] net/bnxt: fix interrupt rearm logic Ajit Khaparde
2019-07-19 6:19 ` [dpdk-stable] [PATCH 6/7] net/bnxt: remove unnecessary interrupt disable Ajit Khaparde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).