From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4290A046B for ; Tue, 23 Jul 2019 03:01:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9649B1BEED; Tue, 23 Jul 2019 03:01:55 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id E8DA71BEE8 for ; Tue, 23 Jul 2019 03:01:54 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 23 Jul 2019 04:01:53 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6N11Hf7026580; Tue, 23 Jul 2019 04:01:52 +0300 From: Yongseok Koh To: David Marchand Cc: dpdk stable Date: Mon, 22 Jul 2019 17:59:48 -0700 Message-Id: <20190723010115.6446-21-yskoh@mellanox.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190723010115.6446-1-yskoh@mellanox.com> References: <20190723010115.6446-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'eal: remove dead code in core list parsing' has been queued to LTS release 17.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 07/27/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Yongseok --- >From 9a2c71e8f02e2e1512c81cd002d1bdf1a21e3ccb Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 13 Feb 2019 21:06:58 +0100 Subject: [PATCH] eal: remove dead code in core list parsing [ upstream commit 33df941d79ad7966b82d882ad277e625f6c3a017 ] We don't need to look for trailing spaces. This is a copy/paste block from eal_parse_coremask(). Remove it and the associated comment. Fixes: d888cb8b9613 ("eal: add core list input format") Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_options.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 535c11f821..d5435ef052 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -529,20 +529,17 @@ static int eal_parse_corelist(const char *corelist) { struct rte_config *cfg = rte_eal_get_configuration(); - int i, idx = 0; unsigned count = 0; char *end = NULL; int min, max; + int idx; if (corelist == NULL) return -1; - /* Remove all blank characters ahead and after */ + /* Remove all blank characters ahead */ while (isblank(*corelist)) corelist++; - i = strlen(corelist); - while ((i > 0) && isblank(corelist[i - 1])) - i--; /* Reset config */ for (idx = 0; idx < RTE_MAX_LCORE; idx++) { -- 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-07-22 17:55:07.646781998 -0700 +++ 0021-eal-remove-dead-code-in-core-list-parsing.patch 2019-07-22 17:55:05.871471000 -0700 @@ -1,14 +1,15 @@ -From 33df941d79ad7966b82d882ad277e625f6c3a017 Mon Sep 17 00:00:00 2001 +From 9a2c71e8f02e2e1512c81cd002d1bdf1a21e3ccb Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 13 Feb 2019 21:06:58 +0100 Subject: [PATCH] eal: remove dead code in core list parsing +[ upstream commit 33df941d79ad7966b82d882ad277e625f6c3a017 ] + We don't need to look for trailing spaces. This is a copy/paste block from eal_parse_coremask(). Remove it and the associated comment. Fixes: d888cb8b9613 ("eal: add core list input format") -Cc: stable@dpdk.org Signed-off-by: David Marchand --- @@ -16,10 +17,10 @@ 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c -index 9e61ee436c..8a431457b0 100644 +index 535c11f821..d5435ef052 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c -@@ -567,10 +567,10 @@ static int +@@ -529,20 +529,17 @@ static int eal_parse_corelist(const char *corelist) { struct rte_config *cfg = rte_eal_get_configuration(); @@ -29,9 +30,6 @@ int min, max; + int idx; - if (eal_service_cores_parsed()) - RTE_LOG(WARNING, EAL, -@@ -580,12 +580,9 @@ eal_parse_corelist(const char *corelist) if (corelist == NULL) return -1;