From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C701CA046B for ; Tue, 23 Jul 2019 03:02:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ACCDA1BF82; Tue, 23 Jul 2019 03:02:41 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 1AB671BF55 for ; Tue, 23 Jul 2019 03:02:40 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 23 Jul 2019 04:02:36 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6N11HfU026580; Tue, 23 Jul 2019 04:02:35 +0300 From: Yongseok Koh To: Anatoly Burakov Cc: dpdk stable Date: Mon, 22 Jul 2019 18:00:11 -0700 Message-Id: <20190723010115.6446-44-yskoh@mellanox.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190723010115.6446-1-yskoh@mellanox.com> References: <20190723010115.6446-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'malloc: fix documentation of realloc function' has been queued to LTS release 17.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 07/27/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Yongseok --- >From f699b4f17796b85733e367883ee576cb728244fa Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Fri, 22 Feb 2019 15:29:29 +0000 Subject: [PATCH] malloc: fix documentation of realloc function [ upstream commit 929a91e99c22c022342382779f3a06ddaabb2ff5 ] The documentation for rte_realloc claims that the resized area will always reside on the same NUMA node. This is not actually the case - while *resized* area will be on the same NUMA node, if resizing the area is not possible, then the memory will be reallocated using rte_malloc(), which can allocate memory on another NUMA node, depending on which lcore rte_realloc() was called from and which NUMA nodes have memory available. Fix the API doc to match the actual code of rte_realloc(). Fixes: af75078fece3 ("first public release") Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_malloc.h b/lib/librte_eal/common/include/rte_malloc.h index 5d4c11a7ca..fbdf01bfed 100644 --- a/lib/librte_eal/common/include/rte_malloc.h +++ b/lib/librte_eal/common/include/rte_malloc.h @@ -139,7 +139,7 @@ rte_calloc(const char *type, size_t num, size_t size, unsigned align); /** * Replacement function for realloc(), using huge-page memory. Reserved area * memory is resized, preserving contents. In NUMA systems, the new area - * resides on the same NUMA socket as the old area. + * may not reside on the same NUMA node as the old one. * * @param ptr * Pointer to already allocated memory -- 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-07-22 17:55:08.902534062 -0700 +++ 0044-malloc-fix-documentation-of-realloc-function.patch 2019-07-22 17:55:06.077474000 -0700 @@ -1,8 +1,10 @@ -From 929a91e99c22c022342382779f3a06ddaabb2ff5 Mon Sep 17 00:00:00 2001 +From f699b4f17796b85733e367883ee576cb728244fa Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Fri, 22 Feb 2019 15:29:29 +0000 Subject: [PATCH] malloc: fix documentation of realloc function +[ upstream commit 929a91e99c22c022342382779f3a06ddaabb2ff5 ] + The documentation for rte_realloc claims that the resized area will always reside on the same NUMA node. This is not actually the case - while *resized* area will be on the same NUMA node, @@ -14,7 +16,6 @@ Fix the API doc to match the actual code of rte_realloc(). Fixes: af75078fece3 ("first public release") -Cc: stable@dpdk.org Signed-off-by: Anatoly Burakov --- @@ -22,10 +23,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_malloc.h b/lib/librte_eal/common/include/rte_malloc.h -index 5fbde4ed8b..5ff1a39a2e 100644 +index 5d4c11a7ca..fbdf01bfed 100644 --- a/lib/librte_eal/common/include/rte_malloc.h +++ b/lib/librte_eal/common/include/rte_malloc.h -@@ -111,7 +111,7 @@ rte_calloc(const char *type, size_t num, size_t size, unsigned align); +@@ -139,7 +139,7 @@ rte_calloc(const char *type, size_t num, size_t size, unsigned align); /** * Replacement function for realloc(), using huge-page memory. Reserved area * memory is resized, preserving contents. In NUMA systems, the new area