From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF25FA046B for ; Tue, 23 Jul 2019 03:02:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2ED21BEF8; Tue, 23 Jul 2019 03:02:45 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 27C2F1BEF8 for ; Tue, 23 Jul 2019 03:02:45 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 23 Jul 2019 04:02:41 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6N11HfW026580; Tue, 23 Jul 2019 04:02:38 +0300 From: Yongseok Koh To: Gavin Hu Cc: Ruifeng Wang , Joyce Kong , Phil Yang , Honnappa Nagarahalli , Ola Liljedahl , Jerin Jacob , Nipun Gupta , Konstantin Ananyev , dpdk stable Date: Mon, 22 Jul 2019 18:00:13 -0700 Message-Id: <20190723010115.6446-46-yskoh@mellanox.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190723010115.6446-1-yskoh@mellanox.com> References: <20190723010115.6446-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test/spinlock: remove delay for correct benchmarking' has been queued to LTS release 17.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 07/27/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Yongseok --- >From 8e802faf2304cbe790c8417547e147d8d6cc55ed Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Fri, 8 Mar 2019 15:56:35 +0800 Subject: [PATCH] test/spinlock: remove delay for correct benchmarking [ upstream commit 9119ad305db027b5c87e27b13fde9d60f9aa9a1f ] The test is to benchmark the performance of spinlock by counting the number of spinlock acquire and release operations within the specified time. A typical pair of lock and unlock operations costs tens or hundreds of nano seconds, in comparison to this, delaying 1 us outside of the locked region is too much, compromising the goal of benchmarking the lock and unlock performance. Fixes: af75078fece3 ("first public release") Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Joyce Kong Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedahl Acked-by: Jerin Jacob Acked-by: Nipun Gupta Acked-by: Konstantin Ananyev --- test/test/test_spinlock.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/test/test_spinlock.c b/test/test/test_spinlock.c index bb34e0c64e..d15edf73ce 100644 --- a/test/test/test_spinlock.c +++ b/test/test/test_spinlock.c @@ -149,8 +149,6 @@ load_loop_fn(void *func_param) lcount++; if (use_lock) rte_spinlock_unlock(&lk); - /* delay to make lock duty cycle slighlty realistic */ - rte_delay_us(1); time_diff = rte_get_timer_cycles() - begin; } lock_count[lcore] = lcount; -- 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-07-22 17:55:09.003096626 -0700 +++ 0046-test-spinlock-remove-delay-for-correct-benchmarking.patch 2019-07-22 17:55:06.089472000 -0700 @@ -1,8 +1,10 @@ -From 9119ad305db027b5c87e27b13fde9d60f9aa9a1f Mon Sep 17 00:00:00 2001 +From 8e802faf2304cbe790c8417547e147d8d6cc55ed Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Fri, 8 Mar 2019 15:56:35 +0800 Subject: [PATCH] test/spinlock: remove delay for correct benchmarking +[ upstream commit 9119ad305db027b5c87e27b13fde9d60f9aa9a1f ] + The test is to benchmark the performance of spinlock by counting the number of spinlock acquire and release operations within the specified time. @@ -12,7 +14,6 @@ unlock performance. Fixes: af75078fece3 ("first public release") -Cc: stable@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang @@ -24,14 +25,14 @@ Acked-by: Nipun Gupta Acked-by: Konstantin Ananyev --- - app/test/test_spinlock.c | 2 -- + test/test/test_spinlock.c | 2 -- 1 file changed, 2 deletions(-) -diff --git a/app/test/test_spinlock.c b/app/test/test_spinlock.c -index 73bff128e6..6795195aee 100644 ---- a/app/test/test_spinlock.c -+++ b/app/test/test_spinlock.c -@@ -120,8 +120,6 @@ load_loop_fn(void *func_param) +diff --git a/test/test/test_spinlock.c b/test/test/test_spinlock.c +index bb34e0c64e..d15edf73ce 100644 +--- a/test/test/test_spinlock.c ++++ b/test/test/test_spinlock.c +@@ -149,8 +149,6 @@ load_loop_fn(void *func_param) lcount++; if (use_lock) rte_spinlock_unlock(&lk);