From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87169A046B for ; Tue, 23 Jul 2019 03:03:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E9C41BEF8; Tue, 23 Jul 2019 03:03:10 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 6F3D41BF81 for ; Tue, 23 Jul 2019 03:03:09 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 23 Jul 2019 04:03:07 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6N11Hfk026580; Tue, 23 Jul 2019 04:03:05 +0300 From: Yongseok Koh To: Stephen Hemminger Cc: Rami Rosen , Maxime Coquelin , dpdk stable Date: Mon, 22 Jul 2019 18:00:27 -0700 Message-Id: <20190723010115.6446-60-yskoh@mellanox.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190723010115.6446-1-yskoh@mellanox.com> References: <20190723010115.6446-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/virtio: remove useless condition' has been queued to LTS release 17.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 07/27/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Yongseok --- >From e18e3c37d7f681e82452b5dd1158f392516ecde7 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 27 Mar 2019 14:08:43 -0700 Subject: [PATCH] net/virtio: remove useless condition [ upstream commit 5c67301273fff63d81c343cee164a3d87918b567 ] Since previous test is for mtu < 1519 the next else if is always true. This causes the lgtm static tool to complain. Not a real issue, just cosmetic. Fixes: 76d4c652e07d ("virtio: add extended stats") Signed-off-by: Stephen Hemminger Acked-by: Rami Rosen Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 275b65f434..a88fb4fd4c 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -632,7 +632,7 @@ virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf) stats->size_bins[0]++; else if (s < 1519) stats->size_bins[6]++; - else if (s >= 1519) + else stats->size_bins[7]++; } -- 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-07-22 17:55:09.720317720 -0700 +++ 0060-net-virtio-remove-useless-condition.patch 2019-07-22 17:55:06.180473000 -0700 @@ -1,14 +1,15 @@ -From 5c67301273fff63d81c343cee164a3d87918b567 Mon Sep 17 00:00:00 2001 +From e18e3c37d7f681e82452b5dd1158f392516ecde7 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 27 Mar 2019 14:08:43 -0700 Subject: [PATCH] net/virtio: remove useless condition +[ upstream commit 5c67301273fff63d81c343cee164a3d87918b567 ] + Since previous test is for mtu < 1519 the next else if is always true. This causes the lgtm static tool to complain. Not a real issue, just cosmetic. Fixes: 76d4c652e07d ("virtio: add extended stats") -Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Rami Rosen @@ -18,10 +19,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c -index ee30084e41..e6f3706d6f 100644 +index 275b65f434..a88fb4fd4c 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c -@@ -1109,7 +1109,7 @@ virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf) +@@ -632,7 +632,7 @@ virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf) stats->size_bins[0]++; else if (s < 1519) stats->size_bins[6]++;