From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DCC3A046B for ; Tue, 23 Jul 2019 03:03:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C9111BFB3; Tue, 23 Jul 2019 03:03:25 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 941EC1BEF8 for ; Tue, 23 Jul 2019 03:03:24 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 23 Jul 2019 04:03:19 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6N11Hfs026580; Tue, 23 Jul 2019 04:03:18 +0300 From: Yongseok Koh To: Pallantla Poornima Cc: David Hunt , dpdk stable Date: Mon, 22 Jul 2019 18:00:35 -0700 Message-Id: <20190723010115.6446-68-yskoh@mellanox.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190723010115.6446-1-yskoh@mellanox.com> References: <20190723010115.6446-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test/distributor: replace sprintf with strlcpy' has been queued to LTS release 17.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 07/27/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Yongseok --- >From 78301c59efc6a02c2209ec76c4a16ad66ab117b1 Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Thu, 14 Feb 2019 09:45:49 +0000 Subject: [PATCH] test/distributor: replace sprintf with strlcpy [ upstream commit 7ab0770233ed5bb89845abf6b978ef15b2520bd8 ] sprintf function is not secure as it doesn't check the length of string. replaced sprintf with strlcpy. Fixes: f74df2c57e ("test/distributor: test single and burst API") Signed-off-by: Pallantla Poornima Acked-by: David Hunt --- test/test/test_distributor.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c index 9fae688b8b..cff3477c59 100644 --- a/test/test/test_distributor.c +++ b/test/test/test_distributor.c @@ -40,6 +40,7 @@ #include #include #include +#include #define ITER_POWER 20 /* log 2 of how many iterations we do when timing. */ #define BURST 32 @@ -671,9 +672,11 @@ test_distributor(void) worker_params.dist = dist[i]; if (i) - sprintf(worker_params.name, "burst"); + strlcpy(worker_params.name, "burst", + sizeof(worker_params.name)); else - sprintf(worker_params.name, "single"); + strlcpy(worker_params.name, "single", + sizeof(worker_params.name)); rte_eal_mp_remote_launch(handle_work, &worker_params, SKIP_MASTER); -- 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-07-22 17:55:10.125933403 -0700 +++ 0068-test-distributor-replace-sprintf-with-strlcpy.patch 2019-07-22 17:55:06.222472000 -0700 @@ -1,25 +1,26 @@ -From 7ab0770233ed5bb89845abf6b978ef15b2520bd8 Mon Sep 17 00:00:00 2001 +From 78301c59efc6a02c2209ec76c4a16ad66ab117b1 Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Thu, 14 Feb 2019 09:45:49 +0000 Subject: [PATCH] test/distributor: replace sprintf with strlcpy +[ upstream commit 7ab0770233ed5bb89845abf6b978ef15b2520bd8 ] + sprintf function is not secure as it doesn't check the length of string. replaced sprintf with strlcpy. Fixes: f74df2c57e ("test/distributor: test single and burst API") -Cc: stable@dpdk.org Signed-off-by: Pallantla Poornima Acked-by: David Hunt --- - app/test/test_distributor.c | 7 +++++-- + test/test/test_distributor.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c -index 98919ec0cc..da3348fd1f 100644 ---- a/app/test/test_distributor.c -+++ b/app/test/test_distributor.c -@@ -11,6 +11,7 @@ +diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c +index 9fae688b8b..cff3477c59 100644 +--- a/test/test/test_distributor.c ++++ b/test/test/test_distributor.c +@@ -40,6 +40,7 @@ #include #include #include @@ -27,7 +28,7 @@ #define ITER_POWER 20 /* log 2 of how many iterations we do when timing. */ #define BURST 32 -@@ -642,9 +643,11 @@ test_distributor(void) +@@ -671,9 +672,11 @@ test_distributor(void) worker_params.dist = dist[i]; if (i)