From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 774F4A046B for ; Tue, 23 Jul 2019 03:03:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6AF2A1BEF8; Tue, 23 Jul 2019 03:03:25 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 949BF1BF94 for ; Tue, 23 Jul 2019 03:03:24 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 23 Jul 2019 04:03:21 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6N11Hft026580; Tue, 23 Jul 2019 04:03:20 +0300 From: Yongseok Koh To: Pallantla Poornima Cc: Yipeng Wang , dpdk stable Date: Mon, 22 Jul 2019 18:00:36 -0700 Message-Id: <20190723010115.6446-69-yskoh@mellanox.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190723010115.6446-1-yskoh@mellanox.com> References: <20190723010115.6446-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test/hash: replace sprintf with snprintf' has been queued to LTS release 17.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 07/27/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Yongseok --- >From 3196b046aa13963fdbd5627c99dbe2a8b9ac4d5a Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Tue, 26 Mar 2019 10:27:23 +0000 Subject: [PATCH] test/hash: replace sprintf with snprintf [ upstream commit 8766e2a4782aecb6d474697617055e281149cc02 ] sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 473d1bebce ("hash: allow to store data in hash table") Signed-off-by: Pallantla Poornima Acked-by: Yipeng Wang --- test/test/test_hash_perf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c index b0514b104f..b965d9b255 100644 --- a/test/test/test_hash_perf.c +++ b/test/test/test_hash_perf.c @@ -112,9 +112,11 @@ create_table(unsigned with_data, unsigned table_index) if (with_data) /* Table will store 8-byte data */ - sprintf(name, "test_hash%d_data", hashtest_key_lens[table_index]); + snprintf(name, sizeof(name), "test_hash%u_data", + hashtest_key_lens[table_index]); else - sprintf(name, "test_hash%d", hashtest_key_lens[table_index]); + snprintf(name, sizeof(name), "test_hash%u", + hashtest_key_lens[table_index]); ut_params.name = name; ut_params.key_len = hashtest_key_lens[table_index]; -- 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-07-22 17:55:10.178141979 -0700 +++ 0069-test-hash-replace-sprintf-with-snprintf.patch 2019-07-22 17:55:06.236472000 -0700 @@ -1,25 +1,26 @@ -From 8766e2a4782aecb6d474697617055e281149cc02 Mon Sep 17 00:00:00 2001 +From 3196b046aa13963fdbd5627c99dbe2a8b9ac4d5a Mon Sep 17 00:00:00 2001 From: Pallantla Poornima Date: Tue, 26 Mar 2019 10:27:23 +0000 Subject: [PATCH] test/hash: replace sprintf with snprintf +[ upstream commit 8766e2a4782aecb6d474697617055e281149cc02 ] + sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 473d1bebce ("hash: allow to store data in hash table") -Cc: stable@dpdk.org Signed-off-by: Pallantla Poornima Acked-by: Yipeng Wang --- - app/test/test_hash_perf.c | 6 ++++-- + test/test/test_hash_perf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c -index 5252111803..5648fce023 100644 ---- a/app/test/test_hash_perf.c -+++ b/app/test/test_hash_perf.c -@@ -85,9 +85,11 @@ create_table(unsigned int with_data, unsigned int table_index, +diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c +index b0514b104f..b965d9b255 100644 +--- a/test/test/test_hash_perf.c ++++ b/test/test/test_hash_perf.c +@@ -112,9 +112,11 @@ create_table(unsigned with_data, unsigned table_index) if (with_data) /* Table will store 8-byte data */ @@ -31,8 +32,8 @@ + snprintf(name, sizeof(name), "test_hash%u", + hashtest_key_lens[table_index]); - - if (with_locks) + ut_params.name = name; + ut_params.key_len = hashtest_key_lens[table_index]; -- 2.21.0