From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D607DA046B for ; Tue, 23 Jul 2019 03:03:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA5251BFD2; Tue, 23 Jul 2019 03:03:50 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id D88231BFA1 for ; Tue, 23 Jul 2019 03:03:49 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 23 Jul 2019 04:03:44 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6N11Hg9026580; Tue, 23 Jul 2019 04:03:43 +0300 From: Yongseok Koh To: Andrew Rybchenko Cc: Bernard Iremonger , dpdk stable Date: Mon, 22 Jul 2019 18:00:50 -0700 Message-Id: <20190723010115.6446-83-yskoh@mellanox.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190723010115.6446-1-yskoh@mellanox.com> References: <20190723010115.6446-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: set fixed flag for exact link speed' has been queued to LTS release 17.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 07/27/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Yongseok --- >From 4d68663719dd3a49c4f9f9e764fef372ec900d77 Mon Sep 17 00:00:00 2001 From: Andrew Rybchenko Date: Fri, 12 Apr 2019 14:12:33 +0100 Subject: [PATCH] app/testpmd: set fixed flag for exact link speed [ upstream commit bdca79053b6aea504d02691d9319fa976062457f ] Setting exact link speed makes sense if auto-negotiation is disabled. Fixed flag is required to disable auto-negotiation. Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function") Signed-off-by: Andrew Rybchenko Acked-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 7a3a818723..b007264e15 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1318,17 +1318,17 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed) return -1; } if (!strcmp(speedstr, "1000")) { - *speed = ETH_LINK_SPEED_1G; + *speed = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_FIXED; } else if (!strcmp(speedstr, "10000")) { - *speed = ETH_LINK_SPEED_10G; + *speed = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_FIXED; } else if (!strcmp(speedstr, "25000")) { - *speed = ETH_LINK_SPEED_25G; + *speed = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_FIXED; } else if (!strcmp(speedstr, "40000")) { - *speed = ETH_LINK_SPEED_40G; + *speed = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_FIXED; } else if (!strcmp(speedstr, "50000")) { - *speed = ETH_LINK_SPEED_50G; + *speed = ETH_LINK_SPEED_50G | ETH_LINK_SPEED_FIXED; } else if (!strcmp(speedstr, "100000")) { - *speed = ETH_LINK_SPEED_100G; + *speed = ETH_LINK_SPEED_100G | ETH_LINK_SPEED_FIXED; } else if (!strcmp(speedstr, "auto")) { *speed = ETH_LINK_SPEED_AUTONEG; } else { -- 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-07-22 17:55:10.947879262 -0700 +++ 0083-app-testpmd-set-fixed-flag-for-exact-link-speed.patch 2019-07-22 17:55:06.388474000 -0700 @@ -1,13 +1,14 @@ -From bdca79053b6aea504d02691d9319fa976062457f Mon Sep 17 00:00:00 2001 +From 4d68663719dd3a49c4f9f9e764fef372ec900d77 Mon Sep 17 00:00:00 2001 From: Andrew Rybchenko Date: Fri, 12 Apr 2019 14:12:33 +0100 Subject: [PATCH] app/testpmd: set fixed flag for exact link speed +[ upstream commit bdca79053b6aea504d02691d9319fa976062457f ] + Setting exact link speed makes sense if auto-negotiation is disabled. Fixed flag is required to disable auto-negotiation. Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function") -Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko Acked-by: Bernard Iremonger @@ -16,10 +17,10 @@ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c -index 2ab03c1113..691d818a6c 100644 +index 7a3a818723..b007264e15 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c -@@ -1440,17 +1440,17 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed) +@@ -1318,17 +1318,17 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed) return -1; } if (!strcmp(speedstr, "1000")) {