From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28119A046B for ; Tue, 23 Jul 2019 03:04:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C2AC1BFF0; Tue, 23 Jul 2019 03:04:16 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 239291BEF8 for ; Tue, 23 Jul 2019 03:04:15 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 23 Jul 2019 04:04:11 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6N11HgO026580; Tue, 23 Jul 2019 04:04:10 +0300 From: Yongseok Koh To: Ferruh Yigit Cc: Bruce Richardson , dpdk stable Date: Mon, 22 Jul 2019 18:01:05 -0700 Message-Id: <20190723010115.6446-98-yskoh@mellanox.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190723010115.6446-1-yskoh@mellanox.com> References: <20190723010115.6446-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ring: fix return value check' has been queued to LTS release 17.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 07/27/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Yongseok --- >From 7989f05f3498ecd1d33ca2fcdf6389efa3b660d5 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 23 Apr 2019 16:23:32 +0100 Subject: [PATCH] net/ring: fix return value check [ upstream commit e0474b94f8a36672d66be7408e3f7cf00e302329 ] 'rte_eth_dev_get_port_by_name()' return value is not checked caught by coverity, adding return value check. Coverity issue: 305853 Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") Signed-off-by: Ferruh Yigit Acked-by: Bruce Richardson --- drivers/net/ring/rte_eth_ring.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index da165152a6..c56dc339d5 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -413,7 +413,11 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[], return -1; } - rte_eth_dev_get_port_by_name(ring_name, &port_id); + ret = rte_eth_dev_get_port_by_name(ring_name, &port_id); + if (ret) { + rte_errno = ENODEV; + return -1; + } return port_id; } -- 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-07-22 17:55:11.762257794 -0700 +++ 0098-net-ring-fix-return-value-check.patch 2019-07-22 17:55:06.476479000 -0700 @@ -1,14 +1,15 @@ -From e0474b94f8a36672d66be7408e3f7cf00e302329 Mon Sep 17 00:00:00 2001 +From 7989f05f3498ecd1d33ca2fcdf6389efa3b660d5 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 23 Apr 2019 16:23:32 +0100 Subject: [PATCH] net/ring: fix return value check +[ upstream commit e0474b94f8a36672d66be7408e3f7cf00e302329 ] + 'rte_eth_dev_get_port_by_name()' return value is not checked caught by coverity, adding return value check. Coverity issue: 305853 Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") -Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Bruce Richardson @@ -17,10 +18,10 @@ 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c -index 979993fd3e..ab963a03c4 100644 +index da165152a6..c56dc339d5 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c -@@ -396,7 +396,11 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[], +@@ -413,7 +413,11 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[], return -1; }