From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, harry.van.haaren@intel.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] test: enable installing test app with meson
Date: Wed, 24 Jul 2019 16:50:43 +0100 [thread overview]
Message-ID: <20190724155042.GC1608@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <806101b6235bd6e8534114898d4de7ea1cb38cac.1563983246.git.anatoly.burakov@intel.com>
On Wed, Jul 24, 2019 at 04:47:31PM +0100, Anatoly Burakov wrote:
> Currently, the test app is not being installed by default when
> built and installed with meson build system. Fix that to enable
> installation of the test app alongside other DPDK apps.
>
> Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test")
> Cc: harry.van.haaren@intel.com
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> app/test/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 1834897bf..c50b20275 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -359,7 +359,7 @@ dpdk_test = executable('dpdk-test',
> dependencies: test_dep_objs,
> c_args: [cflags, '-DALLOW_EXPERIMENTAL_API'],
> install_rpath: driver_install_path,
> - install: false)
> + install: true)
>
I see no major reason not to have it installed - if anyone does not want
the test app, they can disable it completely using the meson option
"tests". Therefore:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2019-07-24 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 15:47 Anatoly Burakov
2019-07-24 15:50 ` Bruce Richardson [this message]
2019-07-30 9:03 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724155042.GC1608@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).