From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65E70A046B for ; Thu, 25 Jul 2019 08:06:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55DE31BE37; Thu, 25 Jul 2019 08:06:05 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1341B1BE37; Thu, 25 Jul 2019 08:06:02 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 23:06:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,305,1559545200"; d="scan'208";a="172538923" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.185]) by orsmga003.jf.intel.com with ESMTP; 24 Jul 2019 23:06:00 -0700 Date: Thu, 25 Jul 2019 20:47:19 +0800 From: Ye Xiaolong To: Qi Zhang Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, lei.yao@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20190725124719.GA57077@intel.com> References: <20190725043829.19440-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190725043829.19440-1-qi.z.zhang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/iavf: fix endless loop X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 07/25, Qi Zhang wrote: >Change loop index from uint16_t to uint32_t since max >index 65535 could be exceeded when ring size is 2k+. > >Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") >Cc: stable@dpdk.org > >Reported-by: Lei Yao >Signed-off-by: Qi Zhang >--- >v2: >- add missing fix in reset_tx_queue. > > drivers/net/iavf/iavf_rxtx.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c >index d8eb6d296..22d7bb612 100644 >--- a/drivers/net/iavf/iavf_rxtx.c >+++ b/drivers/net/iavf/iavf_rxtx.c >@@ -144,7 +144,8 @@ check_rx_bulk_allow(struct iavf_rx_queue *rxq) > static inline void > reset_rx_queue(struct iavf_rx_queue *rxq) > { >- uint16_t len, i; >+ uint16_t len; >+ uint32_t i; > > if (!rxq) > return; >@@ -174,7 +175,8 @@ static inline void > reset_tx_queue(struct iavf_tx_queue *txq) > { > struct iavf_tx_entry *txe; >- uint16_t i, prev, size; >+ uint32_t i, size; >+ uint16_t prev; > > if (!txq) { > PMD_DRV_LOG(DEBUG, "Pointer to txq is NULL"); >-- >2.13.6 > Reviewed-by: Xiaolong Ye