From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26631A046B for ; Fri, 23 Aug 2019 11:44:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1CAB31BF4C; Fri, 23 Aug 2019 11:44:58 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 609031BF4C for ; Fri, 23 Aug 2019 11:44:57 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74ABBA2892A; Fri, 23 Aug 2019 09:44:56 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-48.ams2.redhat.com [10.36.116.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 909F15C226; Fri, 23 Aug 2019 09:44:55 +0000 (UTC) From: Kevin Traynor To: Bao-Long Tran Cc: dpdk stable Date: Fri, 23 Aug 2019 10:43:18 +0100 Message-Id: <20190823094336.12078-28-ktraynor@redhat.com> In-Reply-To: <20190823094336.12078-1-ktraynor@redhat.com> References: <20190823094336.12078-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Fri, 23 Aug 2019 09:44:56 +0000 (UTC) Subject: [dpdk-stable] patch 'examples/l3fwd-vf: remove unused Rx/Tx configuration' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/2cb7e21e536a941ff49652c25a06e1544993e277 Thanks. Kevin Traynor --- >From 2cb7e21e536a941ff49652c25a06e1544993e277 Mon Sep 17 00:00:00 2001 From: Bao-Long Tran Date: Mon, 3 Jun 2019 17:06:18 +0700 Subject: [PATCH] examples/l3fwd-vf: remove unused Rx/Tx configuration [ upstream commit a1d9307b2c0651315fe1a73768a88bacc9c6c59a ] The RX and TX Prefetch, Host, and Write-back threshold values are defined but not used anywhere. They are leftovers from a previous patch. Fixes: 81f7ecd9 ("examples: use factorized default Rx/Tx configuration") Signed-off-by: Bao-Long Tran --- examples/l3fwd-vf/main.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/examples/l3fwd-vf/main.c b/examples/l3fwd-vf/main.c index 41137f978..036f86854 100644 --- a/examples/l3fwd-vf/main.c +++ b/examples/l3fwd-vf/main.c @@ -75,23 +75,4 @@ (unsigned)8192) -/* - * RX and TX Prefetch, Host, and Write-back threshold values should be - * carefully set for optimal performance. Consult the network - * controller's datasheet and supporting DPDK documentation for guidance - * on how these parameters should be set. - */ -#define RX_PTHRESH 8 /**< Default values of RX prefetch threshold reg. */ -#define RX_HTHRESH 8 /**< Default values of RX host threshold reg. */ -#define RX_WTHRESH 4 /**< Default values of RX write-back threshold reg. */ - -/* - * These default values are optimized for use with the Intel(R) 82599 10 GbE - * Controller and the DPDK ixgbe PMD. Consider using other values for other - * network controllers and/or network drivers. - */ -#define TX_PTHRESH 36 /**< Default values of TX prefetch threshold reg. */ -#define TX_HTHRESH 0 /**< Default values of TX host threshold reg. */ -#define TX_WTHRESH 0 /**< Default values of TX write-back threshold reg. */ - #define MAX_PKT_BURST 32 #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */ -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-22 19:38:22.281403036 +0100 +++ 0028-examples-l3fwd-vf-remove-unused-Rx-Tx-configuration.patch 2019-08-22 19:38:20.448026617 +0100 @@ -1 +1 @@ -From a1d9307b2c0651315fe1a73768a88bacc9c6c59a Mon Sep 17 00:00:00 2001 +From 2cb7e21e536a941ff49652c25a06e1544993e277 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a1d9307b2c0651315fe1a73768a88bacc9c6c59a ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 95948676a..1432f8969 100644 +index 41137f978..036f86854 100644