From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EAE5A046B for ; Fri, 23 Aug 2019 11:45:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9515F1BF9F; Fri, 23 Aug 2019 11:45:29 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 276F71BFA6 for ; Fri, 23 Aug 2019 11:45:28 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 95A5330655F5; Fri, 23 Aug 2019 09:45:27 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-48.ams2.redhat.com [10.36.116.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56A955F9D3; Fri, 23 Aug 2019 09:45:26 +0000 (UTC) From: Kevin Traynor To: Jananee Parthasarathy Cc: David Marchand , Cristian Dumitrescu , dpdk stable Date: Fri, 23 Aug 2019 10:43:33 +0100 Message-Id: <20190823094336.12078-43-ktraynor@redhat.com> In-Reply-To: <20190823094336.12078-1-ktraynor@redhat.com> References: <20190823094336.12078-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Fri, 23 Aug 2019 09:45:27 +0000 (UTC) Subject: [dpdk-stable] patch 'table: fix crash in LPM IPv6' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/60c0d21f4123a3e9ff1c17de499fb7be3e8f83c5 Thanks. Kevin Traynor --- >From 60c0d21f4123a3e9ff1c17de499fb7be3e8f83c5 Mon Sep 17 00:00:00 2001 From: Jananee Parthasarathy Date: Tue, 2 Jul 2019 12:21:34 +0100 Subject: [PATCH] table: fix crash in LPM IPv6 [ upstream commit 984d9e522fa0522c2cd15863c9790195a630b0b9 ] Unit test table_autotest results in segmentation fault. Crash occurs in test_table_lpm_ipv6_combined(). Variable 'nht_pos0' used as array subscript is not initialized in rte_table_lpm_ipv6_entry_add(). It will not be assigned, if a rule does not exist. In such case a junk number or invalid array index might result in segmentation fault due to array out of bounds when lpm->nht_users is used with such invalid array index. Fix is to initialize the variables used for array subscript. Bugzilla ID: 285 Fixes: d89a5bce1d ("lpm6: extend next hop field") Signed-off-by: Jananee Parthasarathy Tested-by: David Marchand Acked-by: Cristian Dumitrescu --- lib/librte_table/rte_table_lpm_ipv6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_table/rte_table_lpm_ipv6.c b/lib/librte_table/rte_table_lpm_ipv6.c index a55f808a4..4e068d79b 100644 --- a/lib/librte_table/rte_table_lpm_ipv6.c +++ b/lib/librte_table/rte_table_lpm_ipv6.c @@ -183,5 +183,5 @@ rte_table_lpm_ipv6_entry_add( struct rte_table_lpm_ipv6_key *ip_prefix = key; - uint32_t nht_pos, nht_pos0, nht_pos0_valid; + uint32_t nht_pos = 0, nht_pos0 = 0, nht_pos0_valid = 0; int status; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-22 19:38:23.229472688 +0100 +++ 0043-table-fix-crash-in-LPM-IPv6.patch 2019-08-22 19:38:20.475025974 +0100 @@ -1 +1 @@ -From 984d9e522fa0522c2cd15863c9790195a630b0b9 Mon Sep 17 00:00:00 2001 +From 60c0d21f4123a3e9ff1c17de499fb7be3e8f83c5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 984d9e522fa0522c2cd15863c9790195a630b0b9 ] + @@ -21 +22,0 @@ -Cc: stable@dpdk.org