From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0080BA0613 for ; Tue, 27 Aug 2019 11:31:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC5201BFFA; Tue, 27 Aug 2019 11:31:20 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 45F3054AE for ; Tue, 27 Aug 2019 11:31:19 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B5A81307D88D; Tue, 27 Aug 2019 09:31:18 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-48.ams2.redhat.com [10.36.117.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 85AC05C1B2; Tue, 27 Aug 2019 09:31:17 +0000 (UTC) From: Kevin Traynor To: Fiona Trahe Cc: Tomasz Jozwiak , Shally Verma , dpdk stable Date: Tue, 27 Aug 2019 10:30:02 +0100 Message-Id: <20190827093032.20423-25-ktraynor@redhat.com> In-Reply-To: <20190827093032.20423-1-ktraynor@redhat.com> References: <20190827093032.20423-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 27 Aug 2019 09:31:18 +0000 (UTC) Subject: [dpdk-stable] patch 'doc: clarify data plane error handling in compressdev' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/03/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/8e5fbdfa04c67425e279d804c9b3bb051387383d Thanks. Kevin Traynor --- >From 8e5fbdfa04c67425e279d804c9b3bb051387383d Mon Sep 17 00:00:00 2001 From: Fiona Trahe Date: Wed, 15 May 2019 12:16:07 +0100 Subject: [PATCH] doc: clarify data plane error handling in compressdev [ upstream commit f7095d41bba6ae30d9756dfbe677256851ff879d ] Fixed some typos and clarified how errors on ops which fail to get submitted on the enqueue API should be handled. Fixes: a584d3bea902 ("doc: add compressdev library guide") Signed-off-by: Fiona Trahe Acked-by: Tomasz Jozwiak Acked-by: Shally Verma --- doc/guides/prog_guide/compressdev.rst | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/doc/guides/prog_guide/compressdev.rst b/doc/guides/prog_guide/compressdev.rst index 0f572f970..0e8d8c3d1 100644 --- a/doc/guides/prog_guide/compressdev.rst +++ b/doc/guides/prog_guide/compressdev.rst @@ -202,5 +202,5 @@ Operation Status ~~~~~~~~~~~~~~~~ Each operation carries a status information updated by PMD after it is processed. -following are currently supported status: +Following are currently supported: - RTE_COMP_OP_STATUS_SUCCESS, @@ -228,4 +228,14 @@ following are currently supported status: next op in the stream should continue on from op.consumed+1. +Operation status after enqueue / dequeue +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +Some of the above values may arise in the op after an +``rte_compressdev_enqueue_burst()``. If number ops enqueued < number ops requested then +the app should check the op.status of nb_enqd+1. If status is RTE_COMP_OP_STATUS_NOT_PROCESSED, +it likely indicates a full-queue case for a hardware device and a retry after dequeuing some ops is likely +to be successful. If the op holds any other status, e.g. RTE_COMP_OP_STATUS_INVALID_ARGS, a retry with +the same op is unlikely to be successful. + + Produced, Consumed And Operation Status ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -234,6 +244,6 @@ Produced, Consumed And Operation Status consumed = amount of data read from input buffer, and produced = amount of data written in destination buffer -- If status is RTE_COMP_OP_STATUS_FAILURE, - consumed = produced = 0 or undefined +- If status is RTE_COMP_OP_STATUS_ERROR, + consumed = produced = undefined - If status is RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED, consumed = 0 and -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-27 09:40:12.277229495 +0100 +++ 0025-doc-clarify-data-plane-error-handling-in-compressdev.patch 2019-08-27 09:40:10.908144679 +0100 @@ -1 +1 @@ -From f7095d41bba6ae30d9756dfbe677256851ff879d Mon Sep 17 00:00:00 2001 +From 8e5fbdfa04c67425e279d804c9b3bb051387383d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f7095d41bba6ae30d9756dfbe677256851ff879d ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 07332d004..dd3e40bff 100644 +index 0f572f970..0e8d8c3d1 100644