From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FC20A0613 for ; Tue, 27 Aug 2019 11:31:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 31D2D1C0BD; Tue, 27 Aug 2019 11:31:24 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5104E1BFFA for ; Tue, 27 Aug 2019 11:31:23 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C5B018BA2D8; Tue, 27 Aug 2019 09:31:22 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-48.ams2.redhat.com [10.36.117.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id B6BEA5C22F; Tue, 27 Aug 2019 09:31:21 +0000 (UTC) From: Kevin Traynor To: Tomasz Jozwiak Cc: Akhil Goyal , dpdk stable Date: Tue, 27 Aug 2019 10:30:05 +0100 Message-Id: <20190827093032.20423-28-ktraynor@redhat.com> In-Reply-To: <20190827093032.20423-1-ktraynor@redhat.com> References: <20190827093032.20423-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Tue, 27 Aug 2019 09:31:22 +0000 (UTC) Subject: [dpdk-stable] patch 'app/crypto-perf: check lcore job failure' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/03/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/08e8a0ed44ee22f3fa39d55a3982ceca886f6058 Thanks. Kevin Traynor --- >From 08e8a0ed44ee22f3fa39d55a3982ceca886f6058 Mon Sep 17 00:00:00 2001 From: Tomasz Jozwiak Date: Fri, 14 Jun 2019 22:56:45 +0200 Subject: [PATCH] app/crypto-perf: check lcore job failure [ upstream commit 5908e7e837a62fe62c48094d8c2e947242f8fac3 ] Currently, there's no return status check from lcore's jobs. In case of fail - crypto-perf tool returns success anyway. This patch adds such a detection and returns proper status at the end. Fixes: ce8af1a4398d ("app/crypto-perf: wait for cores launched by app") Signed-off-by: Tomasz Jozwiak Acked-by: Akhil Goyal --- app/test-crypto-perf/main.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 0aa0de8bd..921394799 100644 --- a/app/test-crypto-perf/main.c +++ b/app/test-crypto-perf/main.c @@ -628,7 +628,10 @@ main(int argc, char **argv) if (i == total_nb_qps) break; - rte_eal_wait_lcore(lcore_id); + ret |= rte_eal_wait_lcore(lcore_id); i++; } + + if (ret != EXIT_SUCCESS) + goto err; } else { @@ -655,8 +658,11 @@ main(int argc, char **argv) if (i == total_nb_qps) break; - rte_eal_wait_lcore(lcore_id); + ret |= rte_eal_wait_lcore(lcore_id); i++; } + if (ret != EXIT_SUCCESS) + goto err; + /* Get next size from range or list */ if (opts.inc_buffer_size != 0) -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-27 09:40:12.436112978 +0100 +++ 0028-app-crypto-perf-check-lcore-job-failure.patch 2019-08-27 09:40:10.911144607 +0100 @@ -1 +1 @@ -From 5908e7e837a62fe62c48094d8c2e947242f8fac3 Mon Sep 17 00:00:00 2001 +From 08e8a0ed44ee22f3fa39d55a3982ceca886f6058 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5908e7e837a62fe62c48094d8c2e947242f8fac3 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index db0290751..ce92a9687 100644 +index 0aa0de8bd..921394799 100644 @@ -23 +24 @@ -@@ -666,7 +666,10 @@ main(int argc, char **argv) +@@ -628,7 +628,10 @@ main(int argc, char **argv) @@ -35 +36 @@ -@@ -693,8 +696,11 @@ main(int argc, char **argv) +@@ -655,8 +658,11 @@ main(int argc, char **argv)