From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C9E0A0613 for ; Tue, 27 Aug 2019 11:31:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 51D991C0BD; Tue, 27 Aug 2019 11:31:45 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 902351BFE1 for ; Tue, 27 Aug 2019 11:31:43 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 063474E832; Tue, 27 Aug 2019 09:31:43 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-48.ams2.redhat.com [10.36.117.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F5285C1D6; Tue, 27 Aug 2019 09:31:42 +0000 (UTC) From: Kevin Traynor To: Bernard Iremonger Cc: dpdk stable Date: Tue, 27 Aug 2019 10:30:18 +0100 Message-Id: <20190827093032.20423-41-ktraynor@redhat.com> In-Reply-To: <20190827093032.20423-1-ktraynor@redhat.com> References: <20190827093032.20423-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 27 Aug 2019 09:31:43 +0000 (UTC) Subject: [dpdk-stable] patch 'flow_classify: fix out-of-bounds access' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/03/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/5c0e9b1077b4c95d4a8b5612d603466dc23c620f Thanks. Kevin Traynor --- >From 5c0e9b1077b4c95d4a8b5612d603466dc23c620f Mon Sep 17 00:00:00 2001 From: Bernard Iremonger Date: Tue, 9 Jul 2019 12:09:56 +0100 Subject: [PATCH] flow_classify: fix out-of-bounds access [ upstream commit 8d244bb3a32ee54364f8c0a7b7244a67ad407091 ] This patch fixes the out-of-bounds coverity issue by removing the offending line of code at line 107 in rte_flow_classify_parse.c which is never executed. Coverity issue: 343454 Fixes: be41ac2a330f ("flow_classify: introduce flow classify library") Signed-off-by: Bernard Iremonger --- lib/librte_flow_classify/rte_flow_classify_parse.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_flow_classify/rte_flow_classify_parse.c b/lib/librte_flow_classify/rte_flow_classify_parse.c index f65ceaf7c..465330291 100644 --- a/lib/librte_flow_classify/rte_flow_classify_parse.c +++ b/lib/librte_flow_classify/rte_flow_classify_parse.c @@ -104,6 +104,4 @@ classify_pattern_skip_void_item(struct rte_flow_item *items, break; } - - pb = pe + 1; } /* Copy the END item. */ -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-27 09:40:13.152936799 +0100 +++ 0041-flow_classify-fix-out-of-bounds-access.patch 2019-08-27 09:40:10.936144000 +0100 @@ -1 +1 @@ -From 8d244bb3a32ee54364f8c0a7b7244a67ad407091 Mon Sep 17 00:00:00 2001 +From 5c0e9b1077b4c95d4a8b5612d603466dc23c620f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8d244bb3a32ee54364f8c0a7b7244a67ad407091 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org