From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73CF7A0613 for ; Wed, 28 Aug 2019 15:42:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6BC7F1C219; Wed, 28 Aug 2019 15:42:41 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C2D081C219 for ; Wed, 28 Aug 2019 15:42:40 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 421BA882F2; Wed, 28 Aug 2019 13:42:40 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3515B194B2; Wed, 28 Aug 2019 13:42:38 +0000 (UTC) From: Kevin Traynor To: Arek Kusztal Cc: Fiona Trahe , dpdk stable Date: Wed, 28 Aug 2019 14:41:37 +0100 Message-Id: <20190828134234.20547-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 28 Aug 2019 13:42:40 +0000 (UTC) Subject: [dpdk-stable] patch 'crypto/openssl: fix free of asymmetric crypto keys' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/04/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/78807f9b4ffeec5593f7cdb8189cc58a776f369c Thanks. Kevin Traynor --- >From 78807f9b4ffeec5593f7cdb8189cc58a776f369c Mon Sep 17 00:00:00 2001 From: Arek Kusztal Date: Mon, 1 Jul 2019 16:57:25 +0200 Subject: [PATCH] crypto/openssl: fix free of asymmetric crypto keys [ upstream commit 77411bd6387b28e91eac1702c872712f09c62c4b ] In case big number need to be freed, data it contains should also be cleared before especially if it is critical data like private keys. Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations") Cc: stable@dpdk.org Signed-off-by: Arek Kusztal Acked-by: Fiona Trahe --- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c index d382476a6..234089c88 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c @@ -912,12 +912,12 @@ static int openssl_set_asym_session_parameters( break; err_rsa: - BN_free(n); - BN_free(e); - BN_free(d); - BN_free(p); - BN_free(q); - BN_free(dmp1); - BN_free(dmq1); - BN_free(iqmp); + BN_clear_free(n); + BN_clear_free(e); + BN_clear_free(d); + BN_clear_free(p); + BN_clear_free(q); + BN_clear_free(dmp1); + BN_clear_free(dmq1); + BN_clear_free(iqmp); return -1; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-28 14:32:31.839894192 +0100 +++ 0002-crypto-openssl-fix-free-of-asymmetric-crypto-keys.patch 2019-08-28 14:32:31.579958742 +0100 @@ -1 +1 @@ -From 77411bd6387b28e91eac1702c872712f09c62c4b Mon Sep 17 00:00:00 2001 +From 78807f9b4ffeec5593f7cdb8189cc58a776f369c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 77411bd6387b28e91eac1702c872712f09c62c4b ] + @@ -20 +22 @@ -index 40217cf0d..a307c91ec 100644 +index d382476a6..234089c88 100644 @@ -23 +25 @@ -@@ -913,12 +913,12 @@ static int openssl_set_asym_session_parameters( +@@ -912,12 +912,12 @@ static int openssl_set_asym_session_parameters(