From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B6FAA0613 for ; Wed, 28 Aug 2019 15:43:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7222E1BF82; Wed, 28 Aug 2019 15:43:08 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id BD9781C242 for ; Wed, 28 Aug 2019 15:43:07 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0487330842B0; Wed, 28 Aug 2019 13:43:07 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id ACE9B196AE; Wed, 28 Aug 2019 13:43:05 +0000 (UTC) From: Kevin Traynor To: Dilshod Urazov Cc: Andrew Rybchenko , Olivier Matz , dpdk stable Date: Wed, 28 Aug 2019 14:41:54 +0100 Message-Id: <20190828134234.20547-18-ktraynor@redhat.com> In-Reply-To: <20190828134234.20547-1-ktraynor@redhat.com> References: <20190828134234.20547-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 28 Aug 2019 13:43:07 +0000 (UTC) Subject: [dpdk-stable] patch 'net: adjust L2 length on soft VLAN insertion' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/04/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/6426f92cf57b3ce5d81497e3d5e3e5eb811452a5 Thanks. Kevin Traynor --- >From 6426f92cf57b3ce5d81497e3d5e3e5eb811452a5 Mon Sep 17 00:00:00 2001 From: Dilshod Urazov Date: Mon, 24 Jun 2019 14:46:02 +0100 Subject: [PATCH] net: adjust L2 length on soft VLAN insertion [ upstream commit 42caa11b370e17bdbba498766b0fbad0975d8fa9 ] Layer 2 length must be updated after the prepend to mbuf to keep the length right to be used by other Tx offloads. If the packet has tunnel encapsulation, outer_l2_len should be updated. Otherwise l2_len should be updated. Fixes: c974021a5949 ("ether: add soft vlan encap/decap") Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko Acked-by: Olivier Matz --- lib/librte_net/rte_ether.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index e0d831113..71299d9e9 100644 --- a/lib/librte_net/rte_ether.h +++ b/lib/librte_net/rte_ether.h @@ -411,4 +411,9 @@ static inline int rte_vlan_insert(struct rte_mbuf **m) (*m)->ol_flags &= ~(PKT_RX_VLAN_STRIPPED | PKT_TX_VLAN); + if ((*m)->ol_flags & PKT_TX_TUNNEL_MASK) + (*m)->outer_l2_len += sizeof(struct vlan_hdr); + else + (*m)->l2_len += sizeof(struct vlan_hdr); + return 0; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-28 14:32:32.851666991 +0100 +++ 0019-net-adjust-L2-length-on-soft-VLAN-insertion.patch 2019-08-28 14:32:31.626957694 +0100 @@ -1 +1 @@ -From 42caa11b370e17bdbba498766b0fbad0975d8fa9 Mon Sep 17 00:00:00 2001 +From 6426f92cf57b3ce5d81497e3d5e3e5eb811452a5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 42caa11b370e17bdbba498766b0fbad0975d8fa9 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 8ac1afecc..8a040abf5 100644 +index e0d831113..71299d9e9 100644 @@ -26 +27 @@ -@@ -406,4 +406,9 @@ static inline int rte_vlan_insert(struct rte_mbuf **m) +@@ -411,4 +411,9 @@ static inline int rte_vlan_insert(struct rte_mbuf **m) @@ -30 +31 @@ -+ (*m)->outer_l2_len += sizeof(struct rte_vlan_hdr); ++ (*m)->outer_l2_len += sizeof(struct vlan_hdr); @@ -32 +33 @@ -+ (*m)->l2_len += sizeof(struct rte_vlan_hdr); ++ (*m)->l2_len += sizeof(struct vlan_hdr);