patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Ting Xu <ting.xu@intel.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>, dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/iavf: fix driver crash when enable TSO' has been queued to LTS release 18.11.3
Date: Wed, 28 Aug 2019 14:41:56 +0100	[thread overview]
Message-ID: <20190828134234.20547-20-ktraynor@redhat.com> (raw)
In-Reply-To: <20190828134234.20547-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/04/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/6a1aa84302932d33774aa6492eae4002b6e674de

Thanks.

Kevin Traynor

---
From 6a1aa84302932d33774aa6492eae4002b6e674de Mon Sep 17 00:00:00 2001
From: Ting Xu <ting.xu@intel.com>
Date: Tue, 16 Jul 2019 16:12:25 +0000
Subject: [PATCH] net/iavf: fix driver crash when enable TSO

[ upstream commit e3258d02c21dd9c62797846db568806bf2a57f88 ]

The iavf driver crashes when forwarding packets with TSO
enabled. The reason is that the tx context descriptor
configuration is not transferred to tx-ring. This step is
added in this patch.

Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")

Signed-off-by: Ting Xu <ting.xu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/avf/avf_rxtx.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c
index 52056c770..1073876e4 100644
--- a/drivers/net/avf/avf_rxtx.c
+++ b/drivers/net/avf/avf_rxtx.c
@@ -1584,4 +1584,7 @@ avf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 			uint64_t cd_type_cmd_tso_mss =
 				AVF_TX_DESC_DTYPE_CONTEXT;
+			volatile struct avf_tx_context_desc *ctx_txd =
+				(volatile struct avf_tx_context_desc *)
+							&txr[tx_id];
 
 			txn = &sw_ring[txe->next_id];
@@ -1597,4 +1600,7 @@ avf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 					avf_set_tso_ctx(tx_pkt, tx_offload);
 
+			ctx_txd->type_cmd_tso_mss =
+				rte_cpu_to_le_64(cd_type_cmd_tso_mss);
+
 			AVF_DUMP_TX_DESC(txq, &txr[tx_id], tx_id);
 			txe->last_id = tx_last;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-28 14:32:32.968615501 +0100
+++ 0021-net-iavf-fix-driver-crash-when-enable-TSO.patch	2019-08-28 14:32:31.629957628 +0100
@@ -1 +1 @@
-From e3258d02c21dd9c62797846db568806bf2a57f88 Mon Sep 17 00:00:00 2001
+From 6a1aa84302932d33774aa6492eae4002b6e674de Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit e3258d02c21dd9c62797846db568806bf2a57f88 ]
+
@@ -12 +13,0 @@
-Cc: stable@dpdk.org
@@ -17 +18 @@
- drivers/net/iavf/iavf_rxtx.c | 6 ++++++
+ drivers/net/avf/avf_rxtx.c | 6 ++++++
@@ -20,5 +21,5 @@
-diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
-index 2d37c1705..d8eb6d296 100644
---- a/drivers/net/iavf/iavf_rxtx.c
-+++ b/drivers/net/iavf/iavf_rxtx.c
-@@ -1581,4 +1581,7 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
+diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c
+index 52056c770..1073876e4 100644
+--- a/drivers/net/avf/avf_rxtx.c
++++ b/drivers/net/avf/avf_rxtx.c
+@@ -1584,4 +1584,7 @@ avf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
@@ -26,3 +27,3 @@
- 				IAVF_TX_DESC_DTYPE_CONTEXT;
-+			volatile struct iavf_tx_context_desc *ctx_txd =
-+				(volatile struct iavf_tx_context_desc *)
+ 				AVF_TX_DESC_DTYPE_CONTEXT;
++			volatile struct avf_tx_context_desc *ctx_txd =
++				(volatile struct avf_tx_context_desc *)
@@ -32,2 +33,2 @@
-@@ -1594,4 +1597,7 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
- 					iavf_set_tso_ctx(tx_pkt, tx_offload);
+@@ -1597,4 +1600,7 @@ avf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
+ 					avf_set_tso_ctx(tx_pkt, tx_offload);
@@ -38 +39 @@
- 			IAVF_DUMP_TX_DESC(txq, &txr[tx_id], tx_id);
+ 			AVF_DUMP_TX_DESC(txq, &txr[tx_id], tx_id);

  parent reply	other threads:[~2019-08-28 13:43 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28 13:41 [dpdk-stable] patch 'crypto/openssl: fix free of asymmetric crypto keys' " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'kni: fix segmented mbuf data overflow' " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'crypto/dpaa2_sec: fix handling of session init failure' " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'mk: fix custom kernel directory name' " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'examples/ip_frag: fix stale content of ethdev info' " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/bnx2x: fix reading VF id' " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/bnx2x: fix link events polling for SRIOV' " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/bnx2x: fix fastpath SB allocation " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/tap: remove redundant declarations' " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/af_packet: remove redundant declaration' " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/vhost: " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/null: " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/pcap: " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/ring: " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/virtio_user: " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'raw/skeleton: " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'raw/dpaa2_cmdif: " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net: adjust L2 length on soft VLAN insertion' " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/pcap: fix possible mbuf double freeing' " Kevin Traynor
2019-08-28 13:41 ` Kevin Traynor [this message]
2019-08-28 13:41 ` [dpdk-stable] patch 'app/testpmd: fix show port info routine' " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/ena: fix admin CQ polling for 32-bit' " Kevin Traynor
2019-08-28 13:41 ` [dpdk-stable] patch 'net/bnxt: fix crash on probe failure' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix Tx hang after port stop/start' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix L4 checksum error indication in Rx' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: save the number of EM flow count' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix enabling/disabling interrupts' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: check invalid VNIC in cleanup path' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix compiler warning' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix RxQ count if ntuple filtering is disabled' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: check invalid VNIC id for firmware' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/avf: fix Rx bytes stats' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/i40e: fix MAC removal check' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/i40e: fix SFP X722 with FW4.16' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'doc: fix ethernet addresses in flow API guide' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix error handling in port start' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix check of address mapping' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix adding MAC address' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix unconditional wait in link update' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix setting primary MAC address' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix device init error path' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: reset filters before registering interrupts' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: retry IRQ callback deregistration' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix return values to standard error codes' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix lock release on getting NVM info' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix getting statistics' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix checking result of HWRM command' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix Rx interrupt vector' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: fix interrupt rearm logic' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/bnxt: remove unnecessary interrupt disable' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/e1000: fix buffer overrun while i219 processing DMA' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/mlx5: fix typos in comments' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/dpaa: check multi-segment external buffers' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/dpaa2: fix multi-segment Tx' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/ark: fix queue packet replacement' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/i40e: fix ethernet flow rule' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/i40e: fix flow director rule destroy' " Kevin Traynor
2019-08-28 13:42 ` [dpdk-stable] patch 'net/mlx5: remove redundant item from union' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828134234.20547-20-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=ting.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).