From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C52F9A0613 for ; Wed, 28 Aug 2019 15:43:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BC2161C219; Wed, 28 Aug 2019 15:43:28 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 33ACA1C219 for ; Wed, 28 Aug 2019 15:43:27 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A208D8AC6F9; Wed, 28 Aug 2019 13:43:26 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58ED6194B2; Wed, 28 Aug 2019 13:43:25 +0000 (UTC) From: Kevin Traynor To: Jay Ding Cc: Ajit Khaparde , Randy Schacher , dpdk stable Date: Wed, 28 Aug 2019 14:42:07 +0100 Message-Id: <20190828134234.20547-31-ktraynor@redhat.com> In-Reply-To: <20190828134234.20547-1-ktraynor@redhat.com> References: <20190828134234.20547-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.69]); Wed, 28 Aug 2019 13:43:26 +0000 (UTC) Subject: [dpdk-stable] patch 'net/bnxt: check invalid VNIC id for firmware' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/04/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/35a24dea40f421b86133004de6dd53b1e085be2d Thanks. Kevin Traynor --- >From 35a24dea40f421b86133004de6dd53b1e085be2d Mon Sep 17 00:00:00 2001 From: Jay Ding Date: Wed, 17 Jul 2019 16:11:39 +0530 Subject: [PATCH] net/bnxt: check invalid VNIC id for firmware [ upstream commit e1e5e812f1415b0698f82b4b0fbeb558f3cd7eae ] Add checking for vnic id before sending message to chimp in bnxt_hwrm_vnic_plcmode_cfg(). Fixes: db678d5c2b54 ("net/bnxt: add HWRM VNIC configure") Signed-off-by: Jay Ding Signed-off-by: Ajit Khaparde Reviewed-by: Randy Schacher --- drivers/net/bnxt/bnxt_hwrm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 5abd2aba6..f950440a6 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1390,4 +1390,9 @@ static int bnxt_hwrm_vnic_plcmodes_cfg(struct bnxt *bp, struct hwrm_vnic_plcmodes_cfg_output *resp = bp->hwrm_cmd_resp_addr; + if (vnic->fw_vnic_id == INVALID_HW_RING_ID) { + PMD_DRV_LOG(DEBUG, "VNIC ID %x\n", vnic->fw_vnic_id); + return rc; + } + HWRM_PREP(req, VNIC_PLCMODES_CFG, BNXT_USE_CHIMP_MB); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-28 14:32:33.640843248 +0100 +++ 0032-net-bnxt-check-invalid-VNIC-id-for-firmware.patch 2019-08-28 14:32:31.659956959 +0100 @@ -1 +1 @@ -From e1e5e812f1415b0698f82b4b0fbeb558f3cd7eae Mon Sep 17 00:00:00 2001 +From 35a24dea40f421b86133004de6dd53b1e085be2d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e1e5e812f1415b0698f82b4b0fbeb558f3cd7eae ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index a4e0c2e0c..313459aaf 100644 +index 5abd2aba6..f950440a6 100644 @@ -23 +24 @@ -@@ -1498,4 +1498,9 @@ static int bnxt_hwrm_vnic_plcmodes_cfg(struct bnxt *bp, +@@ -1390,4 +1390,9 @@ static int bnxt_hwrm_vnic_plcmodes_cfg(struct bnxt *bp,