From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DDA4A0613 for ; Wed, 28 Aug 2019 15:43:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C1EF1BF82; Wed, 28 Aug 2019 15:43:40 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id E96F01C246 for ; Wed, 28 Aug 2019 15:43:38 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 68B50308A9E2; Wed, 28 Aug 2019 13:43:38 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2DE35194BE; Wed, 28 Aug 2019 13:43:36 +0000 (UTC) From: Kevin Traynor To: Kalesh AP Cc: Lance Richardson , dpdk stable Date: Wed, 28 Aug 2019 14:42:15 +0100 Message-Id: <20190828134234.20547-39-ktraynor@redhat.com> In-Reply-To: <20190828134234.20547-1-ktraynor@redhat.com> References: <20190828134234.20547-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 28 Aug 2019 13:43:38 +0000 (UTC) Subject: [dpdk-stable] patch 'net/bnxt: fix unconditional wait in link update' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/04/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/052a49557654602d4a3567c81cb761813a6cf4c7 Thanks. Kevin Traynor --- >From 052a49557654602d4a3567c81cb761813a6cf4c7 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Thu, 18 Jul 2019 09:05:58 +0530 Subject: [PATCH] net/bnxt: fix unconditional wait in link update [ upstream commit 0a44537589454a9aba3e9ad392218ad433fbf529 ] There is an unconditional delay in link update op. Fixed it to wait only if wait for request completion is set. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Signed-off-by: Kalesh AP Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index f0b799764..20bca23c7 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -840,9 +840,10 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete) goto out; } + + if (!wait_to_complete || new.link_status) + break; + rte_delay_ms(BNXT_LINK_WAIT_INTERVAL); - - if (!wait_to_complete) - break; - } while (!new.link_status && cnt--); + } while (cnt--); out: -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-28 14:32:34.144590677 +0100 +++ 0040-net-bnxt-fix-unconditional-wait-in-link-update.patch 2019-08-28 14:32:31.689956290 +0100 @@ -1 +1 @@ -From 0a44537589454a9aba3e9ad392218ad433fbf529 Mon Sep 17 00:00:00 2001 +From 052a49557654602d4a3567c81cb761813a6cf4c7 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0a44537589454a9aba3e9ad392218ad433fbf529 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 15048de3f..55b030a2b 100644 +index f0b799764..20bca23c7 100644 @@ -22 +23 @@ -@@ -974,9 +974,10 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete) +@@ -840,9 +840,10 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)