From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 632A0A0613 for ; Wed, 28 Aug 2019 15:42:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C86F1C229; Wed, 28 Aug 2019 15:42:54 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C08051BF82 for ; Wed, 28 Aug 2019 15:42:51 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4119C3175296; Wed, 28 Aug 2019 13:42:51 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83CAA45D4; Wed, 28 Aug 2019 13:42:50 +0000 (UTC) From: Kevin Traynor To: Rasesh Mody Cc: dpdk stable Date: Wed, 28 Aug 2019 14:41:43 +0100 Message-Id: <20190828134234.20547-7-ktraynor@redhat.com> In-Reply-To: <20190828134234.20547-1-ktraynor@redhat.com> References: <20190828134234.20547-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 28 Aug 2019 13:42:51 +0000 (UTC) Subject: [dpdk-stable] patch 'net/bnx2x: fix link events polling for SRIOV' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/04/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/7e669a190758b490ab017739ccc2efb66680b256 Thanks. Kevin Traynor --- >From 7e669a190758b490ab017739ccc2efb66680b256 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Wed, 3 Jul 2019 16:43:12 -0700 Subject: [PATCH] net/bnx2x: fix link events polling for SRIOV [ upstream commit 3423521ba06791211264cae9de196c99424062be ] We do not need to schedule periodic poll for slowpath link events for SRIOV. The link events are handled by the PF driver. Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status") Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c index d2ef8c953..5cff77337 100644 --- a/drivers/net/bnx2x/bnx2x_ethdev.c +++ b/drivers/net/bnx2x/bnx2x_ethdev.c @@ -218,7 +218,10 @@ bnx2x_dev_start(struct rte_eth_dev *dev) /* start the periodic callout */ - if (atomic_load_acq_long(&sc->periodic_flags) == PERIODIC_STOP) { - bnx2x_periodic_start(dev); - PMD_DRV_LOG(DEBUG, sc, "Periodic poll re-started"); + if (IS_PF(sc)) { + if (atomic_load_acq_long(&sc->periodic_flags) == + PERIODIC_STOP) { + bnx2x_periodic_start(dev); + PMD_DRV_LOG(DEBUG, sc, "Periodic poll re-started"); + } } @@ -258,8 +261,8 @@ bnx2x_dev_stop(struct rte_eth_dev *dev) rte_intr_callback_unregister(&sc->pci_dev->intr_handle, bnx2x_interrupt_handler, (void *)dev); - } - /* stop the periodic callout */ - bnx2x_periodic_stop(dev); + /* stop the periodic callout */ + bnx2x_periodic_stop(dev); + } ret = bnx2x_nic_unload(sc, UNLOAD_NORMAL, FALSE); @@ -680,5 +683,7 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf) out: - bnx2x_periodic_stop(eth_dev); + if (IS_PF(sc)) + bnx2x_periodic_stop(eth_dev); + return ret; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-28 14:32:32.206506989 +0100 +++ 0008-net-bnx2x-fix-link-events-polling-for-SRIOV.patch 2019-08-28 14:32:31.602958229 +0100 @@ -1 +1 @@ -From 3423521ba06791211264cae9de196c99424062be Mon Sep 17 00:00:00 2001 +From 7e669a190758b490ab017739ccc2efb66680b256 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3423521ba06791211264cae9de196c99424062be ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 191a3ef6c..cda29e64f 100644 +index d2ef8c953..5cff77337 100644 @@ -21 +22 @@ -@@ -219,7 +219,10 @@ bnx2x_dev_start(struct rte_eth_dev *dev) +@@ -218,7 +218,10 @@ bnx2x_dev_start(struct rte_eth_dev *dev) @@ -35 +36 @@ -@@ -259,8 +262,8 @@ bnx2x_dev_stop(struct rte_eth_dev *dev) +@@ -258,8 +261,8 @@ bnx2x_dev_stop(struct rte_eth_dev *dev) @@ -47 +48 @@ -@@ -681,5 +684,7 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf) +@@ -680,5 +683,7 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf)