From: Tiwei Bie <tiwei.bie@intel.com> To: Maxime Coquelin <maxime.coquelin@redhat.com> Cc: zhihong.wang@intel.com, amorenoz@redhat.com, xiao.w.wang@intel.com, dev@dpdk.org, jfreimann@redhat.com, stable@dpdk.org Subject: Re: [dpdk-stable] [PATCH 14/15] net/virtio: add vDPA op to get notification area Date: Tue, 3 Sep 2019 16:40:56 +0800 Message-ID: <20190903084056.GA9564@___> (raw) In-Reply-To: <e006d023-dedb-d313-6e51-2c8d67266918@redhat.com> On Tue, Sep 03, 2019 at 09:36:54AM +0200, Maxime Coquelin wrote: > On 9/3/19 7:02 AM, Tiwei Bie wrote: > > On Thu, Aug 29, 2019 at 09:59:59AM +0200, Maxime Coquelin wrote: > >> This patch implements the vDPA .get_notify_area() > >> callback. > >> > >> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > >> --- > >> drivers/net/virtio/virtio_vdpa.c | 33 ++++++++++++++++++++++++++++++++ > >> 1 file changed, 33 insertions(+) > >> > >> diff --git a/drivers/net/virtio/virtio_vdpa.c b/drivers/net/virtio/virtio_vdpa.c > >> index e0b2f99ba..e681f527a 100644 > >> --- a/drivers/net/virtio/virtio_vdpa.c > >> +++ b/drivers/net/virtio/virtio_vdpa.c > >> @@ -707,6 +707,38 @@ virtio_vdpa_get_vfio_device_fd(int vid) > >> return list->dev->vfio_dev_fd; > >> } > >> > >> +static int > >> +virtio_vdpa_get_notify_area(int vid, int qid, uint64_t *offset, uint64_t *size) > >> +{ > >> + int did; > >> + struct internal_list *list; > >> + struct virtio_vdpa_device *dev; > >> + struct vfio_region_info reg = { .argsz = sizeof(reg) }; > >> + int ret; > >> + > >> + did = rte_vhost_get_vdpa_device_id(vid); > >> + list = find_internal_resource_by_did(did); > >> + if (list == NULL) { > >> + DRV_LOG(ERR, "Invalid device id: %d", did); > >> + return -1; > >> + } > >> + > >> + dev = list->dev; > >> + > >> + reg.index = dev->hw.notify_region; > >> + ret = ioctl(dev->vfio_dev_fd, VFIO_DEVICE_GET_REGION_INFO, ®); > >> + if (ret) { > >> + DRV_LOG(ERR, "Get not get device region info: %s", > >> + strerror(errno)); > >> + return -1; > >> + } > >> + > >> + *offset = dev->vqs[qid].notify_addr - dev->hw.notify_base + reg.offset; > >> + *size = 0x1000; > > > > It would be better to check whether the size is no less > > than 0x1000, otherwise it's possible to give guest the > > access to other registers of the vdpa device. > > Correct, if offset is not page-aligned, then it would mean one page may > be mapped while not needed. I took the ifcvf driver as example and > forgot to fix it. (Maybe it should also be fixed in ifcvf driver?) The ifcvf hardware will make sure that the notify register will stay in a separate page, so the size is hardcoded in ifcvf driver. Regards, Tiwei > > Thanks, > Maxime > > Regards, > > Tiwei > > > >> + > >> + return 0; > >> +} > >> + > >> static struct rte_vdpa_dev_ops virtio_vdpa_ops = { > >> .get_queue_num = virtio_vdpa_get_queue_num, > >> .get_features = virtio_vdpa_get_features, > >> @@ -716,6 +748,7 @@ static struct rte_vdpa_dev_ops virtio_vdpa_ops = { > >> .set_features = virtio_vdpa_set_features, > >> .get_vfio_group_fd = virtio_vdpa_get_vfio_group_fd, > >> .get_vfio_device_fd = virtio_vdpa_get_vfio_device_fd, > >> + .get_notify_area = virtio_vdpa_get_notify_area, > >> }; > >> > >> static inline int > >> -- > >> 2.21.0 > >>
next prev parent reply index Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-29 7:59 [dpdk-stable] [PATCH 00/15] Introduce Virtio vDPA driver Maxime Coquelin 2019-08-29 7:59 ` [dpdk-stable] [PATCH 01/15] vhost: remove vhost kernel header inclusion Maxime Coquelin 2019-09-02 6:03 ` Tiwei Bie 2019-09-03 7:24 ` Maxime Coquelin 2019-08-29 7:59 ` [dpdk-stable] [PATCH 02/15] vhost: configure vDPA as soon as the device is ready Maxime Coquelin 2019-09-02 8:34 ` Ye Xiaolong 2019-09-02 9:02 ` Wang, Xiao W 2019-09-03 7:34 ` Maxime Coquelin 2019-09-03 10:58 ` Wang, Xiao W 2019-08-29 7:59 ` [dpdk-stable] [PATCH 03/15] net/virtio: move control path fonctions in virtqueue file Maxime Coquelin 2019-09-02 6:05 ` Tiwei Bie 2019-08-29 7:59 ` [dpdk-stable] [PATCH 04/15] net/virtio: add virtio PCI subsystem device ID declaration Maxime Coquelin 2019-09-02 6:14 ` Tiwei Bie 2019-09-03 7:25 ` Maxime Coquelin 2019-08-29 7:59 ` [dpdk-stable] [PATCH 05/15] net/virtio: save notify bar ID in virtio HW struct Maxime Coquelin 2019-09-02 6:17 ` Tiwei Bie 2019-08-29 7:59 ` [dpdk-stable] [PATCH 06/15] net/virtio: add skeleton for virtio vDPA driver Maxime Coquelin 2019-09-02 6:27 ` Tiwei Bie 2019-09-03 7:25 ` Maxime Coquelin 2019-08-29 7:59 ` [dpdk-stable] [PATCH 07/15] net/virtio: add vDPA ops to get number of queue Maxime Coquelin 2019-09-02 6:32 ` Tiwei Bie 2019-08-29 7:59 ` [dpdk-stable] [PATCH 08/15] net/virtio: add virtio vDPA op to get features Maxime Coquelin 2019-09-02 6:43 ` Tiwei Bie 2019-09-03 7:27 ` Maxime Coquelin 2019-08-29 7:59 ` [dpdk-stable] [PATCH 09/15] net/virtio: add virtio vDPA op to get protocol features Maxime Coquelin 2019-09-02 6:46 ` Tiwei Bie 2019-08-29 7:59 ` [dpdk-stable] [PATCH 10/15] net/virtio: add vDPA op to configure and start the device Maxime Coquelin 2019-09-03 5:30 ` Tiwei Bie 2019-09-03 7:40 ` Maxime Coquelin 2019-09-03 8:49 ` Tiwei Bie 2019-09-04 4:06 ` Jason Wang 2019-09-04 6:56 ` Maxime Coquelin 2019-09-05 2:57 ` Tiwei Bie 2019-08-29 7:59 ` [dpdk-stable] [PATCH 11/15] net/virtio: add vDPA op to stop and close " Maxime Coquelin 2019-09-02 7:07 ` Tiwei Bie 2019-09-03 7:30 ` Maxime Coquelin 2019-08-29 7:59 ` [dpdk-stable] [PATCH 12/15] net/virtio: add vDPA op to set features Maxime Coquelin 2019-08-29 7:59 ` [dpdk-stable] [PATCH 13/15] net/virtio: add vDPA ops to get VFIO FDs Maxime Coquelin 2019-09-03 4:47 ` Tiwei Bie 2019-08-29 7:59 ` [dpdk-stable] [PATCH 14/15] net/virtio: add vDPA op to get notification area Maxime Coquelin 2019-09-03 5:02 ` Tiwei Bie 2019-09-03 7:36 ` Maxime Coquelin 2019-09-03 8:40 ` Tiwei Bie [this message] 2019-08-29 8:00 ` [dpdk-stable] [PATCH 15/15] doc: add documentation for Virtio vDPA driver Maxime Coquelin 2019-09-09 11:55 ` [dpdk-stable] [dpdk-dev] [PATCH 00/15] Introduce " Shahaf Shuler 2019-09-10 7:46 ` Maxime Coquelin 2019-09-10 13:44 ` Shahaf Shuler 2019-09-10 13:56 ` Maxime Coquelin 2019-09-11 5:15 ` Shahaf Shuler 2019-09-11 7:15 ` Maxime Coquelin 2019-10-24 6:32 ` [dpdk-stable] " Maxime Coquelin
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190903084056.GA9564@___ \ --to=tiwei.bie@intel.com \ --cc=amorenoz@redhat.com \ --cc=dev@dpdk.org \ --cc=jfreimann@redhat.com \ --cc=maxime.coquelin@redhat.com \ --cc=stable@dpdk.org \ --cc=xiao.w.wang@intel.com \ --cc=zhihong.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches Archives are clonable: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/ public-inbox