patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] net/iavf: fix multi-queue Rx interrupt for VF
@ 2019-09-05  3:22 lunyuan.cui
  2019-09-05 12:16 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
  2019-09-06 11:47 ` [dpdk-stable] [PATCH v2] " lunyuan.cui
  0 siblings, 2 replies; 4+ messages in thread
From: lunyuan.cui @ 2019-09-05  3:22 UTC (permalink / raw)
  To: dev; +Cc: Wenzhuo Lu, lunyuan.cui, stable

The original issue was that the last queue could not
be mapped to the interrupt vector, so the last queue
could not receive the package in the interrupt mode.
This patch fix the issue.

Fixes: d6bde6b5ea ("net/avf: enable Rx interrupt")
Cc: stable@dpdk.org

Signed-off-by: lunyuan.cui <lunyuanx.cui@intel.com>
---
 drivers/net/iavf/iavf_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 8f3907378..6559bfa1f 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -360,7 +360,7 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 			for (i = 0; i < dev->data->nb_rx_queues; i++) {
 				vf->rxq_map[vec] |= 1 << i;
 				intr_handle->intr_vec[i] = vec++;
-				if (vec >= vf->nb_msix)
+				if (vec > vf->nb_msix)
 					vec = IAVF_RX_VEC_START;
 			}
 			PMD_DRV_LOG(DEBUG,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/iavf: fix multi-queue Rx interrupt for VF
  2019-09-05  3:22 [dpdk-stable] [PATCH] net/iavf: fix multi-queue Rx interrupt for VF lunyuan.cui
@ 2019-09-05 12:16 ` " Ye Xiaolong
  2019-09-06 11:47 ` [dpdk-stable] [PATCH v2] " lunyuan.cui
  1 sibling, 0 replies; 4+ messages in thread
From: Ye Xiaolong @ 2019-09-05 12:16 UTC (permalink / raw)
  To: lunyuan.cui; +Cc: dev, Wenzhuo Lu, stable

On 09/05, lunyuan.cui wrote:
>The original issue was that the last queue could not
>be mapped to the interrupt vector, so the last queue
>could not receive the package in the interrupt mode.
>This patch fix the issue.

s/fix/fixes

>
>Fixes: d6bde6b5ea ("net/avf: enable Rx interrupt")

The convention is to have the 12 characters of commit SHA in Fixes tag.

>Cc: stable@dpdk.org
>
>Signed-off-by: lunyuan.cui <lunyuanx.cui@intel.com>

Signature format should be 

Signed-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>

Thanks,
Xiaolong

>---
> drivers/net/iavf/iavf_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
>index 8f3907378..6559bfa1f 100644
>--- a/drivers/net/iavf/iavf_ethdev.c
>+++ b/drivers/net/iavf/iavf_ethdev.c
>@@ -360,7 +360,7 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
> 			for (i = 0; i < dev->data->nb_rx_queues; i++) {
> 				vf->rxq_map[vec] |= 1 << i;
> 				intr_handle->intr_vec[i] = vec++;
>-				if (vec >= vf->nb_msix)
>+				if (vec > vf->nb_msix)
> 					vec = IAVF_RX_VEC_START;
> 			}
> 			PMD_DRV_LOG(DEBUG,
>-- 
>2.17.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-stable] [PATCH v2] net/iavf: fix multi-queue Rx interrupt for VF
  2019-09-05  3:22 [dpdk-stable] [PATCH] net/iavf: fix multi-queue Rx interrupt for VF lunyuan.cui
  2019-09-05 12:16 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
@ 2019-09-06 11:47 ` " lunyuan.cui
  2019-09-11  2:53   ` [dpdk-stable] [dpdk-dev] " Yang, Qiming
  1 sibling, 1 reply; 4+ messages in thread
From: lunyuan.cui @ 2019-09-06 11:47 UTC (permalink / raw)
  To: dev; +Cc: Wenzhuo Lu, lunyuan.cui, stable

The original issue was that the last queue could not
be mapped to the interrupt vector, so the last queue
could not receive the package in the interrupt mode.
This patch fixes the issue.

Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
Cc: stable@dpdk.org

Signed-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>
---
 drivers/net/iavf/iavf_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 8f3907378..6559bfa1f 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -360,7 +360,7 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 			for (i = 0; i < dev->data->nb_rx_queues; i++) {
 				vf->rxq_map[vec] |= 1 << i;
 				intr_handle->intr_vec[i] = vec++;
-				if (vec >= vf->nb_msix)
+				if (vec > vf->nb_msix)
 					vec = IAVF_RX_VEC_START;
 			}
 			PMD_DRV_LOG(DEBUG,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/iavf: fix multi-queue Rx interrupt for VF
  2019-09-06 11:47 ` [dpdk-stable] [PATCH v2] " lunyuan.cui
@ 2019-09-11  2:53   ` " Yang, Qiming
  0 siblings, 0 replies; 4+ messages in thread
From: Yang, Qiming @ 2019-09-11  2:53 UTC (permalink / raw)
  To: Cui, LunyuanX, dev; +Cc: Lu, Wenzhuo, Cui, LunyuanX, stable

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of lunyuan.cui
> Sent: Friday, September 6, 2019 7:48 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Cui, LunyuanX
> <lunyuanx.cui@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/iavf: fix multi-queue Rx interrupt for VF
> 
> The original issue was that the last queue could not be mapped to the
> interrupt vector, so the last queue could not receive the package in the
> interrupt mode.
> This patch fixes the issue.
> 
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>
> ---
>  drivers/net/iavf/iavf_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index 8f3907378..6559bfa1f 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -360,7 +360,7 @@ static int iavf_config_rx_queues_irqs(struct
> rte_eth_dev *dev,
>  			for (i = 0; i < dev->data->nb_rx_queues; i++) {
>  				vf->rxq_map[vec] |= 1 << i;
>  				intr_handle->intr_vec[i] = vec++;
> -				if (vec >= vf->nb_msix)
> +				if (vec > vf->nb_msix)
>  					vec = IAVF_RX_VEC_START;
>  			}
>  			PMD_DRV_LOG(DEBUG,
> --
> 2.17.1

Acked-by: Qiming Yang <qiming.yang@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05  3:22 [dpdk-stable] [PATCH] net/iavf: fix multi-queue Rx interrupt for VF lunyuan.cui
2019-09-05 12:16 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-09-06 11:47 ` [dpdk-stable] [PATCH v2] " lunyuan.cui
2019-09-11  2:53   ` [dpdk-stable] [dpdk-dev] " Yang, Qiming

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox