patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] raw/ifpga/base: dereference before null check
@ 2019-09-17 22:24 Tianfei zhang
  2019-10-24 19:22 ` [dpdk-stable] [dpdk-dev] " David Marchand
  2019-10-25  2:40 ` Ye Xiaolong
  0 siblings, 2 replies; 6+ messages in thread
From: Tianfei zhang @ 2019-09-17 22:24 UTC (permalink / raw)
  To: dev; +Cc: Tianfei zhang, stable

Add pointer null check before dereference.

Coverity issue: 344976
Fixes: 12f92a51 ("raw/ifpga/base: fix retimer link status")
Cc: stable@dpdk.org

Signed-off-by: Tianfei zhang <tianfei.zhang@intel.com>
---
 drivers/raw/ifpga/base/opae_eth_group.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/raw/ifpga/base/opae_eth_group.c b/drivers/raw/ifpga/base/opae_eth_group.c
index d189dd578..be28954e0 100644
--- a/drivers/raw/ifpga/base/opae_eth_group.c
+++ b/drivers/raw/ifpga/base/opae_eth_group.c
@@ -308,9 +308,8 @@ struct eth_group_device *eth_group_probe(void *base)
 
 void eth_group_release(struct eth_group_device *dev)
 {
-	eth_group_hw_uinit(dev);
-
 	if (dev) {
+		eth_group_hw_uinit(dev);
 		dev->status = ETH_GROUP_DEV_NOUSED;
 		opae_free(dev);
 	}
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check
  2019-09-17 22:24 [dpdk-stable] [PATCH] raw/ifpga/base: dereference before null check Tianfei zhang
@ 2019-10-24 19:22 ` " David Marchand
  2019-10-25  1:05   ` Xu, Rosen
  2019-10-25  2:40 ` Ye Xiaolong
  1 sibling, 1 reply; 6+ messages in thread
From: David Marchand @ 2019-10-24 19:22 UTC (permalink / raw)
  To: Rosen Xu, Tianfei zhang; +Cc: dev, dpdk stable

On Tue, Sep 17, 2019 at 4:38 PM Tianfei zhang <tianfei.zhang@intel.com> wrote:
>
> Add pointer null check before dereference.
>
> Coverity issue: 344976
> Fixes: 12f92a51 ("raw/ifpga/base: fix retimer link status")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tianfei zhang <tianfei.zhang@intel.com>

This patch touches a "base driver" file, is this ok ?


-- 
David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check
  2019-10-24 19:22 ` [dpdk-stable] [dpdk-dev] " David Marchand
@ 2019-10-25  1:05   ` Xu, Rosen
  0 siblings, 0 replies; 6+ messages in thread
From: Xu, Rosen @ 2019-10-25  1:05 UTC (permalink / raw)
  To: David Marchand, Zhang, Tianfei; +Cc: dev, dpdk stable

Hi,

> -----Original Message-----
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Friday, October 25, 2019 3:22
> To: Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>
> Cc: dev <dev@dpdk.org>; dpdk stable <stable@dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null
> check
> 
> On Tue, Sep 17, 2019 at 4:38 PM Tianfei zhang <tianfei.zhang@intel.com>
> wrote:
> >
> > Add pointer null check before dereference.
> >
> > Coverity issue: 344976
> > Fixes: 12f92a51 ("raw/ifpga/base: fix retimer link status")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Tianfei zhang <tianfei.zhang@intel.com>
> 
> This patch touches a "base driver" file, is this ok ?

It's just raw/ifpga internal base driver.

> 
> --
> David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check
  2019-09-17 22:24 [dpdk-stable] [PATCH] raw/ifpga/base: dereference before null check Tianfei zhang
  2019-10-24 19:22 ` [dpdk-stable] [dpdk-dev] " David Marchand
@ 2019-10-25  2:40 ` Ye Xiaolong
  2019-10-25 10:29   ` Ferruh Yigit
  1 sibling, 1 reply; 6+ messages in thread
From: Ye Xiaolong @ 2019-10-25  2:40 UTC (permalink / raw)
  To: Tianfei zhang; +Cc: dev, stable

On 09/18, Tianfei zhang wrote:
>Add pointer null check before dereference.
>
>Coverity issue: 344976
>Fixes: 12f92a51 ("raw/ifpga/base: fix retimer link status")
>Cc: stable@dpdk.org
>
>Signed-off-by: Tianfei zhang <tianfei.zhang@intel.com>
>---
> drivers/raw/ifpga/base/opae_eth_group.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/raw/ifpga/base/opae_eth_group.c b/drivers/raw/ifpga/base/opae_eth_group.c
>index d189dd578..be28954e0 100644
>--- a/drivers/raw/ifpga/base/opae_eth_group.c
>+++ b/drivers/raw/ifpga/base/opae_eth_group.c
>@@ -308,9 +308,8 @@ struct eth_group_device *eth_group_probe(void *base)
> 
> void eth_group_release(struct eth_group_device *dev)
> {
>-	eth_group_hw_uinit(dev);
>-
> 	if (dev) {
>+		eth_group_hw_uinit(dev);
> 		dev->status = ETH_GROUP_DEV_NOUSED;
> 		opae_free(dev);
> 	}
>-- 
>2.17.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel. Thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check
  2019-10-25  2:40 ` Ye Xiaolong
@ 2019-10-25 10:29   ` Ferruh Yigit
  2019-10-25 11:47     ` David Marchand
  0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2019-10-25 10:29 UTC (permalink / raw)
  To: Ye Xiaolong, Tianfei zhang; +Cc: dev, stable

On 10/25/2019 3:40 AM, Ye Xiaolong wrote:
> On 09/18, Tianfei zhang wrote:
>> Add pointer null check before dereference.
>>
>> Coverity issue: 344976
>> Fixes: 12f92a51 ("raw/ifpga/base: fix retimer link status")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Tianfei zhang <tianfei.zhang@intel.com>
>> ---
>> drivers/raw/ifpga/base/opae_eth_group.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/raw/ifpga/base/opae_eth_group.c b/drivers/raw/ifpga/base/opae_eth_group.c
>> index d189dd578..be28954e0 100644
>> --- a/drivers/raw/ifpga/base/opae_eth_group.c
>> +++ b/drivers/raw/ifpga/base/opae_eth_group.c
>> @@ -308,9 +308,8 @@ struct eth_group_device *eth_group_probe(void *base)
>>
>> void eth_group_release(struct eth_group_device *dev)
>> {
>> -	eth_group_hw_uinit(dev);
>> -
>> 	if (dev) {
>> +		eth_group_hw_uinit(dev);
>> 		dev->status = ETH_GROUP_DEV_NOUSED;
>> 		opae_free(dev);
>> 	}
>> -- 
>> 2.17.1
>>
> 
> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
> 
> Applied to dpdk-next-net-intel. Thanks.
> 

Should we update the MAINTAINERS file to say that "drivers/raw/ifpga" merges to
the next-net-intel?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check
  2019-10-25 10:29   ` Ferruh Yigit
@ 2019-10-25 11:47     ` David Marchand
  0 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2019-10-25 11:47 UTC (permalink / raw)
  To: Ferruh Yigit, Ye Xiaolong, Thomas Monjalon
  Cc: Tianfei zhang, dev, dpdk stable

On Fri, Oct 25, 2019 at 12:30 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
> >
> > Applied to dpdk-next-net-intel. Thanks.
> >
>
> Should we update the MAINTAINERS file to say that "drivers/raw/ifpga" merges to
> the next-net-intel?

Thanks, this area is, a bit, gray to me.
So a clarification is welcome.


--
David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-17 22:24 [dpdk-stable] [PATCH] raw/ifpga/base: dereference before null check Tianfei zhang
2019-10-24 19:22 ` [dpdk-stable] [dpdk-dev] " David Marchand
2019-10-25  1:05   ` Xu, Rosen
2019-10-25  2:40 ` Ye Xiaolong
2019-10-25 10:29   ` Ferruh Yigit
2019-10-25 11:47     ` David Marchand

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox