patches for DPDK stable branches
 help / color / mirror / Atom feed
From: <michaelsh@marvell.com>
To: <akhil.goyal@nxp.com>
Cc: <stable@dpdk.org>, <dev@dpdk.org>, <marko.kovacevic@intel.com>,
	<lironh@marvell.com>, <michaelsh@marvell.com>
Subject: [dpdk-stable] [PATCH 5/8] examples/fips_validation: fix AES-GCM decryption vector
Date: Thu, 19 Sep 2019 15:12:29 +0300	[thread overview]
Message-ID: <20190919121232.4864-6-michaelsh@marvell.com> (raw)
In-Reply-To: <20190919121232.4864-1-michaelsh@marvell.com>

From: Michael Shamis <michaelsh@marvell.com>

AES-GCM CAVS vectors for decryption set PTlen (plain text length)
but provide crypto text and application expected CTlen to be not
null. Now we assign PTlen to CTlen in decryption scenario and
it allows to application to handle AES-GCM decryption vectors.

Signed-off-by: Michael Shamis <michaelsh@marvell.com>
---
 .../fips_validation/fips_validation_gcm.c     | 23 ++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c
index ea48ddf70..f68b4ea82 100644
--- a/examples/fips_validation/fips_validation_gcm.c
+++ b/examples/fips_validation/fips_validation_gcm.c
@@ -33,10 +33,15 @@
 
 #define NEG_TEST_STR	"FAIL"
 
+static int
+parse_uint8_known_len_hex_str_dec(const char *key,
+						char *src,
+						struct fips_val *val);
+
 struct fips_test_callback gcm_dec_vectors[] = {
 		{KEY_STR, parse_uint8_known_len_hex_str, &vec.aead.key},
 		{IV_STR, parse_uint8_known_len_hex_str, &vec.iv},
-		{CT_STR, parse_uint8_known_len_hex_str, &vec.ct},
+		{CT_STR, parse_uint8_known_len_hex_str_dec, &vec.ct},
 		{AAD_STR, parse_uint8_known_len_hex_str, &vec.aead.aad},
 		{TAG_STR, parse_uint8_known_len_hex_str,
 				&vec.aead.digest},
@@ -123,3 +128,19 @@ parse_test_gcm_init(void)
 
 	return 0;
 }
+
+static int
+parse_uint8_known_len_hex_str_dec(const char *key,
+						char *src,
+						struct fips_val *val)
+{
+	/* AES-GCM CAVS vectors for decryption set PTlen (plain text length)
+	 * but provide crypto text.
+	 * In order to compensate the behavior we assign PTlen to CTlen
+	 * (crypto text length) which is used for calculations
+	 */
+	if (info.op == FIPS_TEST_DEC_AUTH_VERIF)
+		vec.ct.len = vec.pt.len;
+
+	return parse_uint8_known_len_hex_str(key, src, val);
+}
-- 
2.23.0


  parent reply	other threads:[~2019-09-19 11:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19 12:12 [dpdk-stable] [PATCH 0/8] Fips validation fixes michaelsh
2019-09-19 12:12 ` [dpdk-stable] [PATCH 1/8] examples/fips_validation: separation between HMAC-SHA and SHA michaelsh
2019-09-19 12:12 ` [dpdk-stable] [PATCH 2/8] examples/fips_validation: fix structs used for AES-GCM michaelsh
2019-09-19 12:12 ` [dpdk-stable] [PATCH 3/8] examples/fips_validation: initialize IV " michaelsh
2019-09-19 12:12 ` [dpdk-stable] [PATCH 4/8] examples/fips_validation: move digest after cipher text michaelsh
2019-09-19 12:12 ` michaelsh [this message]
2019-09-19 12:12 ` [dpdk-stable] [PATCH 6/8] examples/fips_validation: fix overwrite of KEY line in TDES michaelsh
2019-09-19 12:12 ` [dpdk-stable] [PATCH 7/8] examples/fips_validation: improve algo parsing logic michaelsh
2019-09-19 12:12 ` [dpdk-stable] [PATCH 8/8] examples/fips_validation: fix plain text overwrite michaelsh
2019-09-19 13:15 ` [dpdk-stable] [PATCH 0/8] Fips validation fixes Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190919121232.4864-6-michaelsh@marvell.com \
    --to=michaelsh@marvell.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=lironh@marvell.com \
    --cc=marko.kovacevic@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).