* [dpdk-stable] [PATCH v3 20/22] net/ice/base: fix the bitmap for TCP in RSS
[not found] ` <20190907031629.34666-1-qi.z.zhang@intel.com>
@ 2019-09-07 3:16 ` Qi Zhang
0 siblings, 0 replies; 6+ messages in thread
From: Qi Zhang @ 2019-09-07 3:16 UTC (permalink / raw)
To: wenzhuo.lu, qiming.yang
Cc: dev, xiaolong.ye, Qi Zhang, stable, Zhirun Yan, Paul M Stillwell Jr
Before this patch, if set rule for IPv4 first and then set rule
for TCP with IPv4. The first rule for inner IP will be overwritten
by TCP rule. This is because MAC_IPV6_TUN_MAC_IPV4_PAY using the
same ptgs PTG_TUN_INNER_IPV4_OTHER with MAC_IPV4_TUN_MAC_IPV4_PAY,
this ptype should not in TCP bitmap.
Remove this bit in TCP bitmap.
Fixes: aa1cd410fa64 ("net/ice/base: add flow module")
Cc: stable@dpdk.org
Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ice/base/ice_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
index 87faf5103..b6ed5e549 100644
--- a/drivers/net/ice/base/ice_flow.c
+++ b/drivers/net/ice/base/ice_flow.c
@@ -239,7 +239,7 @@ static const u32 ice_ptypes_udp_il[] = {
/* Packet types for packets with an Innermost/Last TCP header */
static const u32 ice_ptypes_tcp_il[] = {
- 0x04000000, 0x80810102, 0x10204040, 0x42040408,
+ 0x04000000, 0x80810102, 0x10204040, 0x02040408,
0x00810102, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00820000, 0x21084000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
--
2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v4 20/30] net/ice/base: fix the bitmap for TCP in RSS
[not found] ` <20190923062702.3836-1-qi.z.zhang@intel.com>
@ 2019-09-23 6:26 ` Qi Zhang
2019-09-23 6:26 ` [dpdk-stable] [PATCH v4 27/30] net/ice/base: fix alignment isue Qi Zhang
2019-09-23 6:26 ` Qi Zhang
2 siblings, 0 replies; 6+ messages in thread
From: Qi Zhang @ 2019-09-23 6:26 UTC (permalink / raw)
To: wenzhuo.lu, qiming.yang
Cc: dev, xiaolong.ye, Qi Zhang, stable, Zhirun Yan, Paul M Stillwell Jr
Before this patch, if set rule for IPv4 first and then set rule
for TCP with IPv4. The first rule for inner IP will be overwritten
by TCP rule. This is because MAC_IPV6_TUN_MAC_IPV4_PAY using the
same ptgs PTG_TUN_INNER_IPV4_OTHER with MAC_IPV4_TUN_MAC_IPV4_PAY,
this ptype should not in TCP bitmap.
Remove this bit in TCP bitmap.
Fixes: aa1cd410fa64 ("net/ice/base: add flow module")
Cc: stable@dpdk.org
Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ice/base/ice_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
index e0e4fcab6..6782dfaa8 100644
--- a/drivers/net/ice/base/ice_flow.c
+++ b/drivers/net/ice/base/ice_flow.c
@@ -239,7 +239,7 @@ static const u32 ice_ptypes_udp_il[] = {
/* Packet types for packets with an Innermost/Last TCP header */
static const u32 ice_ptypes_tcp_il[] = {
- 0x04000000, 0x80810102, 0x10204040, 0x42040408,
+ 0x04000000, 0x80810102, 0x10204040, 0x02040408,
0x00810102, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00820000, 0x21084000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
--
2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v4 27/30] net/ice/base: fix alignment isue
[not found] ` <20190923062702.3836-1-qi.z.zhang@intel.com>
2019-09-23 6:26 ` [dpdk-stable] [PATCH v4 20/30] " Qi Zhang
@ 2019-09-23 6:26 ` Qi Zhang
2019-09-23 6:26 ` Qi Zhang
2 siblings, 0 replies; 6+ messages in thread
From: Qi Zhang @ 2019-09-23 6:26 UTC (permalink / raw)
To: wenzhuo.lu, qiming.yang
Cc: dev, xiaolong.ye, Qi Zhang, stable, Tony Nguyen, Paul M Stillwell Jr
As title says, fix an alignment issue.
Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module")
Cc: stable@dpdk.org
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ice/base/ice_flex_pipe.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c
index 11601f2c2..0357fbd4e 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -131,8 +131,9 @@ static struct ice_buf_table *ice_find_buf_table(struct ice_seg *ice_seg)
{
struct ice_nvm_table *nvms;
- nvms = (struct ice_nvm_table *)(ice_seg->device_table +
- LE32_TO_CPU(ice_seg->device_table_count));
+ nvms = (struct ice_nvm_table *)
+ (ice_seg->device_table +
+ LE32_TO_CPU(ice_seg->device_table_count));
return (_FORCE_ struct ice_buf_table *)
(nvms->vers + LE32_TO_CPU(nvms->table_count));
--
2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v4 27/30] net/ice/base: fix alignment isue
[not found] ` <20190923062702.3836-1-qi.z.zhang@intel.com>
2019-09-23 6:26 ` [dpdk-stable] [PATCH v4 20/30] " Qi Zhang
2019-09-23 6:26 ` [dpdk-stable] [PATCH v4 27/30] net/ice/base: fix alignment isue Qi Zhang
@ 2019-09-23 6:26 ` Qi Zhang
2 siblings, 0 replies; 6+ messages in thread
From: Qi Zhang @ 2019-09-23 6:26 UTC (permalink / raw)
To: wenzhuo.lu, qiming.yang
Cc: dev, xiaolong.ye, Qi Zhang, stable, Tony Nguyen, Paul M Stillwell Jr
As title says, fix an alignment issue.
Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module")
Cc: stable@dpdk.org
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ice/base/ice_flex_pipe.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c
index 11601f2c2..0357fbd4e 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -131,8 +131,9 @@ static struct ice_buf_table *ice_find_buf_table(struct ice_seg *ice_seg)
{
struct ice_nvm_table *nvms;
- nvms = (struct ice_nvm_table *)(ice_seg->device_table +
- LE32_TO_CPU(ice_seg->device_table_count));
+ nvms = (struct ice_nvm_table *)
+ (ice_seg->device_table +
+ LE32_TO_CPU(ice_seg->device_table_count));
return (_FORCE_ struct ice_buf_table *)
(nvms->vers + LE32_TO_CPU(nvms->table_count));
--
2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v5 20/30] net/ice/base: fix the bitmap for TCP in RSS
[not found] ` <20190923074448.7847-1-qi.z.zhang@intel.com>
@ 2019-09-23 7:44 ` Qi Zhang
2019-09-23 7:44 ` [dpdk-stable] [PATCH v5 27/30] net/ice/base: fix alignment isue Qi Zhang
1 sibling, 0 replies; 6+ messages in thread
From: Qi Zhang @ 2019-09-23 7:44 UTC (permalink / raw)
To: wenzhuo.lu, qiming.yang
Cc: dev, xiaolong.ye, Qi Zhang, stable, Zhirun Yan, Paul M Stillwell Jr
Before this patch, if set rule for IPv4 first and then set rule
for TCP with IPv4. The first rule for inner IP will be overwritten
by TCP rule. This is because MAC_IPV6_TUN_MAC_IPV4_PAY using the
same ptgs PTG_TUN_INNER_IPV4_OTHER with MAC_IPV4_TUN_MAC_IPV4_PAY,
this ptype should not in TCP bitmap.
Remove this bit in TCP bitmap.
Fixes: aa1cd410fa64 ("net/ice/base: add flow module")
Cc: stable@dpdk.org
Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ice/base/ice_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
index e0e4fcab6..6782dfaa8 100644
--- a/drivers/net/ice/base/ice_flow.c
+++ b/drivers/net/ice/base/ice_flow.c
@@ -239,7 +239,7 @@ static const u32 ice_ptypes_udp_il[] = {
/* Packet types for packets with an Innermost/Last TCP header */
static const u32 ice_ptypes_tcp_il[] = {
- 0x04000000, 0x80810102, 0x10204040, 0x42040408,
+ 0x04000000, 0x80810102, 0x10204040, 0x02040408,
0x00810102, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00820000, 0x21084000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
--
2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v5 27/30] net/ice/base: fix alignment isue
[not found] ` <20190923074448.7847-1-qi.z.zhang@intel.com>
2019-09-23 7:44 ` [dpdk-stable] [PATCH v5 20/30] net/ice/base: fix the bitmap for TCP in RSS Qi Zhang
@ 2019-09-23 7:44 ` Qi Zhang
1 sibling, 0 replies; 6+ messages in thread
From: Qi Zhang @ 2019-09-23 7:44 UTC (permalink / raw)
To: wenzhuo.lu, qiming.yang
Cc: dev, xiaolong.ye, Qi Zhang, stable, Tony Nguyen, Paul M Stillwell Jr
As title says, fix an alignment issue.
Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module")
Cc: stable@dpdk.org
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ice/base/ice_flex_pipe.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c
index 11601f2c2..0357fbd4e 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -131,8 +131,9 @@ static struct ice_buf_table *ice_find_buf_table(struct ice_seg *ice_seg)
{
struct ice_nvm_table *nvms;
- nvms = (struct ice_nvm_table *)(ice_seg->device_table +
- LE32_TO_CPU(ice_seg->device_table_count));
+ nvms = (struct ice_nvm_table *)
+ (ice_seg->device_table +
+ LE32_TO_CPU(ice_seg->device_table_count));
return (_FORCE_ struct ice_buf_table *)
(nvms->vers + LE32_TO_CPU(nvms->table_count));
--
2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-23 7:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190902035551.16852-1-qi.z.zhang@intel.com>
[not found] ` <20190907031629.34666-1-qi.z.zhang@intel.com>
2019-09-07 3:16 ` [dpdk-stable] [PATCH v3 20/22] net/ice/base: fix the bitmap for TCP in RSS Qi Zhang
[not found] ` <20190923062702.3836-1-qi.z.zhang@intel.com>
2019-09-23 6:26 ` [dpdk-stable] [PATCH v4 20/30] " Qi Zhang
2019-09-23 6:26 ` [dpdk-stable] [PATCH v4 27/30] net/ice/base: fix alignment isue Qi Zhang
2019-09-23 6:26 ` Qi Zhang
[not found] ` <20190923074448.7847-1-qi.z.zhang@intel.com>
2019-09-23 7:44 ` [dpdk-stable] [PATCH v5 20/30] net/ice/base: fix the bitmap for TCP in RSS Qi Zhang
2019-09-23 7:44 ` [dpdk-stable] [PATCH v5 27/30] net/ice/base: fix alignment isue Qi Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).