From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3E01A0613 for ; Thu, 26 Sep 2019 16:44:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D96822BE2; Thu, 26 Sep 2019 16:44:27 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7EE2A2BE2; Thu, 26 Sep 2019 16:44:26 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 07:44:25 -0700 X-IronPort-AV: E=Sophos;i="5.64,552,1559545200"; d="scan'208";a="273420569" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.95]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 07:44:23 -0700 Date: Thu, 26 Sep 2019 15:44:20 +0100 From: Bruce Richardson To: Ciara Power Cc: dev@dpdk.org, romanx.korynkevych@intel.com, vipin.varghese@intel.com, stable@dpdk.org Message-ID: <20190926144420.GA1833@bricha3-MOBL.ger.corp.intel.com> References: <20190926151159.19256-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190926151159.19256-1-ciara.power@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/proc-info: fix string copying to use strlcpy X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Sep 26, 2019 at 04:11:59PM +0100, Ciara Power wrote: > Replaced strncpy and strcpy with strlcpy. > Also replaced snprintf with strlcpy where applicable. > Using strlcpy is safe practice when copying strings, > as it will include a null terminator. > > Cc: romanx.korynkevych@intel.com > Cc: vipin.varghese@intel.com > Cc: stable@dpdk.org > > Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id") > Fixes: 8a37f37fc243 ("app/procinfo: add --show-port") > Reported-by: Reshma Pattan > Signed-off-by: Ciara Power > --- +1 for using strlcpy over strncpy Acked-by: Bruce Richardson