From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Zhang Xiao <xiao.zhang@intel.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, marcdevel@gmail.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] net/ixgbe: fix X553 wrong speed capability
Date: Mon, 30 Sep 2019 18:45:20 +0800 [thread overview]
Message-ID: <20190930104520.GG112560@intel.com> (raw)
In-Reply-To: <1569379794-54847-1-git-send-email-xiao.zhang@intel.com>
On 09/25, Zhang Xiao wrote:
>The speed capability of X553 1GbE should be ETH_LINK_SPEED_1G |
>ETH_LINK_SPEED_100M | ETH_LINK_SPEED_10M rather than ETH_LINK_SPEED_1G |
>ETH_LINK_SPEED_10G. Correct it to fix the issue.
>
>Fixes: e274f5732225 ("ethdev: add speed capabilities")
>Cc: marcdevel@gmail.com
>Cc: stable@dpdk.org
>
>Signed-off-by: Zhang Xiao <xiao.zhang@intel.com>
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>index 7eb3d05..e7c4ce3 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -3843,6 +3843,11 @@ ixgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
> dev_info->flow_type_rss_offloads = IXGBE_RSS_OFFLOAD_ALL;
>
> dev_info->speed_capa = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_10G;
>+ if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T ||
>+ hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L)
>+ dev_info->speed_capa = ETH_LINK_SPEED_10M |
>+ ETH_LINK_SPEED_100M | ETH_LINK_SPEED_1G;
>+
> if (hw->mac.type == ixgbe_mac_X540 ||
> hw->mac.type == ixgbe_mac_X540_vf ||
> hw->mac.type == ixgbe_mac_X550 ||
>--
>2.7.4
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
next prev parent reply other threads:[~2019-09-30 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 2:49 [dpdk-stable] " Zhang Xiao
2019-09-25 7:04 ` [dpdk-stable] [dpdk-dev] " Gavin Hu (Arm Technology China)
2019-09-25 8:16 ` Zhang, Xiao
2019-09-25 9:06 ` Gavin Hu (Arm Technology China)
2019-09-30 10:45 ` Ye Xiaolong [this message]
2019-09-30 10:47 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930104520.GG112560@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=marcdevel@gmail.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).