From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Thierry Herbelot <thierry.herbelot@6wind.com>
Cc: dev@dpdk.org, Laurent Hardy <laurent.hardy@6wind.com>,
Thomas Monjalon <thomas@monjalon.net>,
stable@dpdk.org, beilei.xing@intel.com, qi.z.zhang@intel.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: set speed to undefined for default case in link update
Date: Mon, 30 Sep 2019 18:53:54 +0800 [thread overview]
Message-ID: <20190930105354.GI112560@intel.com> (raw)
In-Reply-To: <2121840c6dc59bcd1caffa8f4c8428fed5d667a7.1568216789.git.thierry.herbelot@6wind.com>
On 09/11, Thierry Herbelot wrote:
>From: Laurent Hardy <laurent.hardy@6wind.com>
>
>During PF/VF link update, a default speed value of 100M will be set
>if get_link_info has failed or speed is unknown.
>
>Consequently if PF is put in no-carrier state, VFs will switch to
>"in carrier" state due to a link up + a link speed set to 100M
>(default value if no speed detected).
>
>To be consistent with linux drivers on which PF and VFs are in
>same carrier state, sets default speed to undefined (instead of 100M)
>and updates a link status of VF only if link is up and speed is
>different from undefined.
>
>Fixes: 4861cde46116 ('i40e: new poll mode driver')
>Cc: stable@dpdk.org
>Cc: beilei.xing@intel.com
>Cc: qi.z.zhang@intel.com
>
>Signed-off-by: Laurent Hardy <laurent.hardy@6wind.com>
>---
> drivers/net/i40e/i40e_ethdev.c | 4 ++--
> drivers/net/i40e/i40e_ethdev_vf.c | 8 +++++---
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel.
prev parent reply other threads:[~2019-09-30 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 16:02 [dpdk-stable] " Thierry Herbelot
2019-09-17 2:40 ` Zhang, Qi Z
2019-09-30 10:53 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930105354.GI112560@intel.com \
--to=xiaolong.ye@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=laurent.hardy@6wind.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=thierry.herbelot@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).