From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F313A2F6B for ; Tue, 8 Oct 2019 10:23:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E5EE51BFEF; Tue, 8 Oct 2019 10:23:52 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2FB031BFAF; Tue, 8 Oct 2019 10:23:49 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 67B2B3003715; Tue, 8 Oct 2019 08:23:48 +0000 (UTC) Received: from amorenoz.users.ipa.redhat.com (ovpn-117-37.ams2.redhat.com [10.36.117.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6BDA860BE0; Tue, 8 Oct 2019 08:23:44 +0000 (UTC) From: Adrian Moreno To: dev@dpdk.org Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, maxime.coquelin@redhat.com, Adrian Moreno , stable@dpdk.org Date: Tue, 8 Oct 2019 10:23:31 +0200 Message-Id: <20191008082334.21244-1-amorenoz@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 08 Oct 2019 08:23:48 +0000 (UTC) Subject: [dpdk-stable] [PATCH v4 0/3] vhost: add support for IOVA_VA mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Currently, IOVAs are assumed to be GPA when the dirty page logging is performed. Add support for guest IOVA_VA mode by translating addresses to GPA before doing the dirty page logging. Also, the guest_pages tracking mechanism used for zero_copy will not work either if IOVA_VA is enabled. In fact, enabling dequeue_zero_copy and IOMMU is dangerous altogether because IOTLB invalidation of guest pages can happen while the buffers are being used. So, ensure this cannot happen by preventing both features to be activated simultaneously. Further information: https://bugs.dpdk.org/show_bug.cgi?id=337 Fixes: 69c90e98f483 ("vhost: enable IOMMU support") Cc: maxime.coquelin@redhat.com Cc: stable@dpdk.org --- v4 changes: Address review comments v3 changes: Address style warnings v2 changes: Also translate buffer addresses ---- Adrian Moreno (3): vhost: translate incoming log address to gpa vhost: convert buffer addresses to GPA for logging vhost: prevent zero copy mode if iommu is on lib/librte_vhost/rte_vhost.h | 2 +- lib/librte_vhost/socket.c | 8 ++++++ lib/librte_vhost/vdpa.c | 3 ++- lib/librte_vhost/vhost.c | 41 ++++++++++++++++++++++++++++ lib/librte_vhost/vhost.h | 51 +++++++++++++++++++++++++++++++++++ lib/librte_vhost/vhost_user.c | 44 +++++++++++++++++++++++++++++- lib/librte_vhost/virtio_net.c | 12 +++++---- 7 files changed, 153 insertions(+), 8 deletions(-) -- 2.21.0